HL-864, HL-875: Fix failing submit for handler #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2153 +/- ##
============================================
- Coverage 30.01% 11.80% -18.22%
============================================
Files 816 160 -656
Lines 16766 4465 -12301
Branches 3645 1115 -2530
============================================
- Hits 5032 527 -4505
+ Misses 11122 3768 -7354
+ Partials 612 170 -442
... and 656 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2153.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2153.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2153.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkibenefit-bf-appl-2153.test.kuva.hel.ninja! 😆🎉🎉🎉 |
sirtawast
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✨
Crashed as the frontend couldn't parse the backend error message related to the missing terms. This fixes error message parsing.
Also, added fixture for handler terms to avoid this happening in the future.
Modified
seedcommand to seed handler applications also (HL-875).