HL-870 | Wrong number of applications on front page's tabs #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2147 +/- ##
===========================================
- Coverage 20.65% 11.80% -8.85%
===========================================
Files 577 160 -417
Lines 11918 4463 -7455
Branches 2887 1114 -1773
===========================================
- Hits 2462 527 -1935
+ Misses 9052 3767 -5285
+ Partials 404 169 -235
... and 444 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2147.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2147.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2147.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkibenefit-bf-appl-2147.test.kuva.hel.ninja! 😆🎉🎉🎉 |
mjturt
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✨
Application numbers were shown wrong. Implementation was a bit pricy earlier so I ended up refactoring the whole
<ApplicationList>.<ApplicationList>no longer fetches data by it's own. Data flows now from parent to component which means there's less queries.If invalidation / stale data later becomes an issue, then implement
onClickinvalidation for<TabPanel>or refactoruseApplicationQuerytouseApplicationListQueryfor single AND application query and apply where needed.