MVJ-470 Avoid PicklingError in email reports #753
+114
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing complex objects to django-q async_task results in a PicklingError during serialization which prevents report creation. This change avoids the problem by only passing module-level functions and regular Python data structures to async_task and between the asynchronous function and the hook.
Without this property, the async task would use the default timeout, which is currently too short at 90 seconds.
This reverts commit aa3acb4. Trying out whether the change was at all needed
This is just in case, because async email reports appear to sometimes get eternally stuck in the queues if the worker is killed by a timeout.
henrinie-nc
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing complex objects to django-q async_task results in a PicklingError during serialization which prevents report creation.
This change avoids the problem by only passing module-level functions and regular Python data structures to async_task and between the asynchronous function and the hook.