Develop to master #751
Merged
Develop to master #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the function without dry_run=True causes a side effect that causes unnecessary updates to RentAdjustment objects in case the value is 0, it is updated to 0.00.
verified by running statistics report with dry_run not set for calculate_rent_amount_for_year()
* Customize SAP export XML for AKV - isolate common functionality from the previous Make/Tontit logic - add a new invoice sales order adapter for AKV - add a factory function to instantiate the adapters based on service unit ID, and fix old tests to use that factory - add unit tests for the new AKV logic AKV requested customizations for their SAP export XML from MVJ. I created a bespoke sales order adapter for AKV, and a factory function that initializes the sales invoice adapter based on the service unit ID. The original adapter contains the Make/Tontit logic, which has been and will be the default export logic for all other service units until otherwise requested. * Add enums to avoid magic variables and duplication - ServiceUnitId - SapSalesOfficeNumber - SapSalesOrgNumber * Add type hints, extract functions, and improve comments. * Remove hardcoded parameter to municipality_factory This avoids unnecessarily crashing this test when unrelated tests have already created at least 10 municipalities via the factory function before running this test case. * Clarify in docstrings how to utilize temporary directories in testing * Add mypy type check for invoice_sales_order_adapter.py - mypy: Install missing type stubs - mypy: signature compatible with base class - mypy: fix incompatible types in assignment - mypy: add missing return statements - mypy: add type definition to parameter
This is for corner cases where some input item might be missing, and would result in ugly output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.