Added email sending feature into direct reservation link create serializer #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasiVuohijoki
force-pushed
the
feature/executive_search_link
branch
3 times, most recently
from
543db8d
to
a46629f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #507 +/- ##
===========================================
+ Coverage 75.60% 75.62% +0.01%
===========================================
Files 436 436
Lines 22993 23033 +40
Branches 2306 2309 +3
===========================================
+ Hits 17385 17418 +33
- Misses 5174 5179 +5
- Partials 434 436 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vinikvuo
reviewed
Jul 28, 2023
locale/fi/LC_MESSAGES/django.po
Outdated
| @@ -384,6 +384,21 @@ msgctxt "Section type" | |||
| msgid "Show if" | |||
| msgstr "Näytä, jos" | |||
|
|
|||
| #, fuzzy | |||
locale/fi/LC_MESSAGES/django.po
Outdated
| @@ -3440,6 +3455,18 @@ msgstr "" | |||
| "Ilmoitusviestien vastaanottajat. Esimerkki: [email protected],maija@example." | |||
| "com" | |||
|
|
|||
| msgctxt "Area search lessor" | |||
| msgid "Aluekäyttö- ja valvonta" | |||
There was a problem hiding this comment.
Message id should be in English
locale/fi/LC_MESSAGES/django.po
Outdated
| @@ -3448,6 +3475,34 @@ msgctxt "Search class" | |||
| msgid "Other" | |||
| msgstr "Muu kilpailu tai haku" | |||
|
|
|||
| #, fuzzy | |||
|
|
||
| #, fuzzy | ||
| #| msgid "File not available" | ||
| msgctxt "Decline reason" |
locale/fi/LC_MESSAGES/django.po
Outdated
| msgctxt "Model name" | ||
| msgid "Area search sub intended use" | ||
| msgstr "Aluehaun alikäyttötarkoitus" | ||
| #, fuzzy |
locale/fi/LC_MESSAGES/django.po
Outdated
| msgctxt "Model name" | ||
| msgid "Area search sub intended uses" | ||
| msgstr "Aluehaun alikäyttötarkoitukset" | ||
| #, fuzzy |
| covering_note = validated_data.pop("covering_note") | ||
| send_copy = validated_data.pop("send_copy") | ||
| send_email = validated_data.pop("send_mail") | ||
| instance = super().create(validated_data) |
There was a problem hiding this comment.
So this creates DirectReservationLink model without any of information above?
There was a problem hiding this comment.
yes. All this popped information is related to email sending.
| instance = super().create(validated_data) | ||
|
|
||
| if send_email: | ||
| receivers = [email] |
There was a problem hiding this comment.
If I remember correctly, black was ranting against it. In tuples comma is needed to make a difference between regular parenthesis
| covering_note, | ||
| language, | ||
| ), | ||
| None, |
There was a problem hiding this comment.
This should be something like "[email protected]"
There was a problem hiding this comment.
Default sender is configured in settings.py
PasiVuohijoki
force-pushed
the
feature/executive_search_link
branch
from
a46629f
to
d8b9f94
Compare
vinikvuo
approved these changes
Aug 7, 2023
PasiVuohijoki
force-pushed
the
feature/executive_search_link
branch
from
d8b9f94
to
85e3d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.