Hds 2460 general documentation updates #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe to add CommonHTMLAttributes as data-* to props.
The arrow icon takes now space. Therefore it needed a background color and container and aligner elements.
…date The old command has rimraf which removes all images.
Include showArrow and information -props to the component props
…from Table Heading id is created when needed Table id was for checkbox and it is also created when needed. Updated docs, tests and snapshot.
Better usage of core css. Cannot use compose in core, so not-so-inconvenient "helper-text-gap" was added.
…exists Short HelperText stays on same line as ErrorText
Flexbox change requires label + tooltip combination to be wrapped. Made external components or otherwise focus would be lost from tooltip button on re-render, if anonymous functions were used.
…ve and rename react tests to react-* and core added to core-*, add core build to workflow
Added only takeAllStorySnapshots, other changes are from prettier.
Missing "yarn" before tsc causes it to be run globally
Notification errors only show with ts-check-stories. Caused by incompatible child types. Unknown why ts-check does not show it, or VSCode.
Dialog icon was not shown before
… playwright tests, add body spacing to helper for body-overflowing pages
… write instructions
…e small props-bugs
Removed aria-label descripiton when not necessary or useful.
Update breadcrumbs to stable, dropdown to deprecated, header to beta. Add content to migration guide.
Test Results 1 files 18 suites 3m 27s ⏱️ Results for commit c66143d. |
|
Preview found from hds-demo docs/preview_1378 Demos |
|
This pr is again not working properly, starting a new one an closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's quite many things in documentation that require updating when moving to next major version 4.0.0
Related Issue
Closes HDS-2460
Motivation and Context
How Has This Been Tested?
demosite
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog
these updates tell more about previous changes already described in changelog