HDS-2448: Fix data-test-id with Logo #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit c20fbe8. |
|
Preview found from hds-demo docs/preview_1372 Demos |
laurakarhu
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logo props were changed to accept all native props, but it already had them. The “…rest” changed places in the code, so now the dataTestId always overrides the data-testid.
Related Issue
Closes HDS-2448
How Has This Been Tested?
Add Jest test.
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog