Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2451: Export graphQLModule hooks #1371

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Oct 7, 2024

Description

All hooks were not exported.
Changed the login stories to use imports from the index file to make sure all are exported properly.

Related Issue

Closes HDS-2451

How Has This Been Tested?

With Storybook

Demos:

Links to demos are in the comments

Note: Logging in does not work in automated demos, because login urls must be registered to backend and urls keep changing in demos.

Screenshots (if appropriate):

Add to changelog

  • [ x] Added needed line to changelog

@NikoHelle NikoHelle requested a review from a team October 7, 2024 06:45
Copy link

github-actions bot commented Oct 7, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e7aa497.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 7, 2024

Preview found from hds-demo docs/preview_1371

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Changed the login stories to use imports from the index file to make sure all are exported properly.
@NikoHelle NikoHelle merged commit de00218 into development Oct 8, 2024
9 checks passed
@NikoHelle NikoHelle deleted the hds-2451-login-exports branch October 8, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants