Hds 2396 core scss v4 for checkbox #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview found from hds-demo docs/preview_1370 Demos |
Test Results 1 files 26 suites 4m 19s ⏱️ Results for commit 598fe7f. ♻️ This comment has been updated with latest results. |
timwessman
force-pushed
the
hds-2396-core-scss-v4-for-checkbox
branch
from
ac4d013
to
55bde63
Compare
|
Hmm... wonder why the visual tests fail for SelectionGroup 🤔 |
NikoHelle
force-pushed
the
release-4.0.0
branch
from
e33d8e6
to
d48fe2d
Compare
timwessman
force-pushed
the
hds-2396-core-scss-v4-for-checkbox
branch
from
dc89665
to
598fe7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE:
SelectionGroup. I can't find out why. The failingSelectrionGroup-story looks pixel perfect in Storybook, but on visual-test, margin between helper-text and checkboxes are couple of pixels smaller than it should.Related Issue
Closes HDS-2396
How Has This Been Tested?
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog