release-4.0.0 HDS-2388 icon template native attributes #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 14 suites 2m 49s ⏱️ Results for commit 6aa54c9. ♻️ This comment has been updated with latest results. |
mrTuomoK
force-pushed
the
HDS-2388-icon-template-native-attributes
branch
2 times, most recently
from
0b33297
to
c509c90
Compare
|
Preview found from hds-demo docs/preview_1360 Demos |
NikoHelle
approved these changes
Sep 11, 2024
mrTuomoK
force-pushed
the
HDS-2388-icon-template-native-attributes
branch
from
baa509a
to
fd98d90
Compare
mrTuomoK
force-pushed
the
HDS-2388-icon-template-native-attributes
branch
from
fd98d90
to
6aa54c9
Compare
laurakarhu
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User native props instead of typing ourselves, removed useless "aria-hidden" props from lots of places since it's the default value for it in Icons, fixed some small other component props to use enums instead of raw string values (yeah sorry for this, should maybe be in another ticker, but was touching the files already :P ). Also tweaked Gatsby Playground.js's sanitazion a bit to remove
;from the end of the code -> would crash the previews.Also includes the changed Icon components since had to run the iconkit-workflow to create them from the template. This is usually done automatically for all *release branches.
Related Issue
Closes HDS-2388
How Has This Been Tested?
Demos:
Links to demos are in the comments
Add to changelog