Release-4.0.0: (HDS-2069) New Select part 3 (rebased) #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed util functions to be clearer.
Sometimes text interpolation needs option.label, so it should be passable.
List components are created according to what (accessibility) attributes and props the components require. Single selects and multi selects without groups have same kind of props for the list components Single selects with group have own props and then there is still multi select with groups. Currently the list elements are missing some aria-attributes, so axe tests are failing, but rules are loosened.
Only 2 rows of selected tags should be shown, so this is needed there.
Dropped old virtualization system for accessibility reasons. Option components are memoized so re-rendering even large lists after a multiselect group click is fast. The bottleneck is (was) the first render when menu is clicked. With long lists, the initial opening can be so slow, the user clicks again. And closes the menu. Solution is to render options in chunks. The useRenderChildrenInChunks hook, renders list items tick by tick, so initial render is fast and user sees no difference.
Test Results1 files 4 suites 1m 12s ⏱️ Results for commit 7320c5b. |
|
Preview found from hds-demo docs/preview_1358 Demos |
mrTuomoK
approved these changes
Sep 17, 2024
laurakarhu
approved these changes
Sep 20, 2024
packages/react/src/components/select/components/list/listItems/MultiSelectOption.tsx
Show resolved
Hide resolved
packages/react/src/components/select/components/list/listItems/SingleSelectOption.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rebased version of older PR
Description
Note: Target branch is the feature branch of the select
Third part of the new Select.
Added:
Related Issue
Closes HDS-2069
How Has This Been Tested?
Added unit tests
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog
Added in last PR