HDS-2384: Hide mobilemenu actionItems when menu is closed #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit b6c7628. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1342 Demos |
NikoHelle
force-pushed
the
HDS-2384-header-hidden-nav
branch
2 times, most recently
from
b6ba257
to
5d40201
Compare
mrTuomoK
reviewed
Sep 11, 2024
...ges/react/src/components/header/components/headerActionBar/HeaderActionBarNavigationMenu.tsx
Outdated
Show resolved
Hide resolved
mrTuomoK
requested changes
Oct 1, 2024
NikoHelle
force-pushed
the
HDS-2384-header-hidden-nav
branch
2 times, most recently
from
e0cd253
to
340bf35
Compare
The items could be navigated with keyboard. Added a wrapper to hide all items.
NikoHelle
force-pushed
the
HDS-2384-header-hidden-nav
branch
from
340bf35
to
b6c7628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The visually hidden items could be navigated with keyboard.
Mobile menu contents are visually hidden when menu is closed and while not animating.
Changes in the visual tests are because the bottom line is shifted a bit, now that menu contents are not taking visual space.
Attached diff images:
Related Issue
Closes HDS-2384
How Has This Been Tested?
With VoiceOver
Demos:
Links to demos are in the comments
Add to changelog
No need for changelog.