Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2115 fix header children #1304

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

NikoHelle
Copy link
Contributor

Description

All header children cannot be hidden to the menu in mobile

Add to changelog

  • no need

@laurakarhu laurakarhu requested a review from mrTuomoK July 2, 2024 11:34
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

github-actions bot commented Jul 2, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit cb15c4c.

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

github-actions bot commented Jul 2, 2024

Preview found from hds-demo docs/preview_1304

Demos

Docs
Core Storybook
React Storybook

@mrTuomoK mrTuomoK merged commit 97eeac8 into development Jul 2, 2024
8 checks passed
@mrTuomoK mrTuomoK deleted the hds-2115-fix-header-children branch July 2, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants