Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint no-important warning #1303

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Jul 1, 2024

Description

  • Adds Stylelint rule "declaration-no-important": [ true, { "severity": "warning" }]

Motivation and Context

  • Using !important in styles is a bad habit which we want to discourage.

How Has This Been Tested?

  • local machine

Add to changelog

Not needed

@mrTuomoK mrTuomoK requested a review from a team July 1, 2024 12:31
Copy link

github-actions bot commented Jul 1, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 868a551.

Copy link

github-actions bot commented Jul 1, 2024

Preview found from hds-demo docs/preview_1303

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrTuomoK mrTuomoK merged commit 246d85e into development Jul 2, 2024
8 checks passed
@mrTuomoK mrTuomoK deleted the add-stylelint-no-important-warning branch July 2, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants