UHF-10581 #565
Merged
UHF-10581 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indexing request after migration for the joblistings that are published on migration
tuutti
requested changes
Oct 7, 2024
public/modules/custom/helfi_google_api/src/Plugin/QueueWorker/IndexingWorker.php
Outdated
Show resolved
Hide resolved
public/modules/custom/helfi_google_api/src/Plugin/QueueWorker/IndexingWorker.php
Outdated
Show resolved
Hide resolved
| * | ||
| * @group helfi_google_api | ||
| */ | ||
| class IndexingTest extends ExistingSiteTestBase { |
There was a problem hiding this comment.
You should test what happens if the API request fails as well.
tuutti
approved these changes
Oct 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test features
How to install
git checkout UHF-10581make freshHow to test
select * from queue, you should see the indexing job in the table