Remove custom module for news search (moved to HDBT)

[jeremysteerio]

UHF-8638

Move news archive app to HDBT.

What was done

In this branch:

• Moved all news archive code to HDBT
  • ...Including styles
• Updated news view template to include correct script from HDBT

In HDBT:

• Reworked news archive app to work with HDBT 'framework' for react apps
  • Removed reliance on reactivesearch
• Codebase for the app is like 80% remade so here are some highlights that need extra attention:
  • Instead of initaiting filter options in store like job search app does, refactored initialization into a swr hook (see useInitialQuery.tsx, FormContainer.tsx)
  • Speaking of swr hooks, made a reusable wrapper hook for swr hooks, maybe this might be of use in future for a common component? See: useIndexQuery.tsx.
  • Added loading overlay and used keepPreviousData arg for swr to create a better transition when updating the app (prevents "collapsing" and inidicates loading better for the user). Added components for the transition into common components, see ResultWrapper.tsx and LoadingOverlay.tsx
  • Used react reft for the 'jump to results' scrolling (see useEffect in ResultsContainer.tsx

In platform config:

• Added news archive block code from the custom module there

How to install

• Make sure your instance is up and running on correct branch.
  • git checkout origin/UHF-8638-move-news-archive-to-hdbt
  • Add ELASTIC_PROXY_URL=https://uutisapi.hel.fi to your .env file (use data from prod to display results)
  • composer require drupal/hdbt:dev-UHF-8638-move-news-archive-to-hdbt
  • composer require drupal/helfi_platform_config:dev-UHF-8638-move-news-archive-to-hdbt
  • Run make fresh

How to test

• Navigate to https://helfi-etusivu.docker.so/fi/uutiset.
• Test the app:
  • Filtering works
  • Pagination works
  • Choices update the params in the url
  • Reloading the page with params presents displays correct results

Designers review

• This PR does not need designers review
• This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

• UHF-8638: Move news archive to HDBT drupal-hdbt#713
• UHF-8638: Add archive block code helfi_react_search module drupal-helfi-platform-config#556

[Jussiles]

Looks good and 🪨 s! I added some comments on HDBT PR.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication