Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8691: Remove alt-text manipulation when caption or photographer information is available #1090

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 18, 2024

UHF-8691

What was done

  • Remove alt-text manipulation when caption or photographer information is available

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8691
  • Run make drush-cr

How to test

  • Go to basic page or landing page and add two new image paragraphs. Add one with image that has alt text and one with alt text only as "" and for both of the images add the photographer and the caption. Save the content.
  • Now make sure that the images alt text is just the alt text that you added without any changes such as photographer information or caption text.
  • Make sure the caption text is visible and correct and that it the photographer information as a suffix. For the image with just the "" as alt text it should have empty alt text attribute.
  • Now check the same things for news main image.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1090/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants