TAN-2973 Replace old date range picker #9907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
luucvanderzee
commented
Dec 24, 2024
front/app/utils/dateUtils.ts
Outdated
| // This function makes sure that the date is always interpreted as midnight in the user's timezone. | ||
| const backendDatestringRegex = /^\d{4}-\d{2}-\d{2}$/; | ||
|
|
||
| export const parseBackendDateString = (dateString?: string) => { |
There was a problem hiding this comment.
I think I finally solved all the stupid 'one day off' errors. We just have to make sure to use this utility whenever we receive a string from the backend that has the format yyyy-MM-DD
|
@EdwinKato functional test would be most important here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
Fixed