TAN-3444 - Prevent custom form saving if updated more recently in another browser window #9888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…ng' into TAN-3444-improve-form-save-logging
jamesspeake
commented
Jan 3, 2025
| %i[options options.image map_config] | ||
| super + %i[map_config] |
There was a problem hiding this comment.
Just tidying up this
jamesspeake
commented
Jan 3, 2025
| @@ -63,14 +63,15 @@ def as_geojson | |||
|
|
|||
| def update_all | |||
| authorize CustomField.new(resource: @custom_form), :update_all?, policy_class: IdeaCustomFieldPolicy | |||
| @participation_method = @custom_form.participation_context.pmethod | |||
There was a problem hiding this comment.
Did not need setting as a global variable
jamesspeake
changed the title
jamesspeake
commented
Jan 3, 2025
| triggerAutosave && | ||
| autosaveEnabled && | ||
| totalSubmissions === 0 && | ||
| isDirty |
There was a problem hiding this comment.
Added this to prevent it saving when there are no changes
EdwinKato
approved these changes
Jan 6, 2025
| import { CustomFormKeys, ICustomForm, ICustomFormParameters } from './types'; | ||
|
|
||
| const fetchCustomForm = ({ projectId, phaseId }: ICustomFormParameters) => { | ||
| const apiEndpoint = phaseId |
There was a problem hiding this comment.
I think for surveys, we will always have a phaseId 🤔. But this might also be in other places so we could probably enforce it separately in another ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works:
Changelog
Changed
Technical