[NO-TICKET] Fix preview mailers index #9869
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of preview mailers at
localhost:4000/rails/mailers
was broken because the newly introducedPreviewMailer
interfered with the lazy loading of mailer previews.Here's how
ActionMailer::Preview
determines the list of previews:The
load_previews
method is only triggered ifdescendants
is empty. However, sincePreviewMailer
was defined in an autoloaded path and is a subclass ofActionMailer::Preview
, it was loaded too early and short-circuited the loading of the other mailer previews.The fix consists of moving the
PreviewMailer
class to the same folder as the other mailer previews. The downside is that now it needs to be required explicitly in the previewers that use it.Changelog
Technical