TAN-3350 - Refactor sso & verification methods with clearer structure and more code sharing #9843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesspeake
changed the base branch from
master
to
TAN-3350-bring-verification-into-core
|
adessy
approved these changes
Jan 8, 2025
| def all_methods | ||
| self.class.all_methods | ||
| IdMethod.all_methods.filter_map { |k, v| [k, v] if v.auth? }.to_h |
There was a problem hiding this comment.
Suggested change
| IdMethod.all_methods.filter_map { |k, v| [k, v] if v.auth? }.to_h | |
| IdMethod.all_methods.select { |_, v| v.auth? } |
| @@ -30,7 +30,7 @@ | |||
| # the state of the request. Especially large strings are stored in fixtures. | |||
| describe OmniAuth::Strategies::AzureActiveDirectory do | |||
| let(:app) { ->(_) { [200, {}, ['Hello world.']] } } | |||
| let(:x5c) { Rails.root.join('spec/fixtures/azure_active_directory/x5c.txt').read } | |||
| let(:x5c) { Rails.root.join('engines/commercial/id_azure_active_directory/spec/fixtures/x5c.txt').read } | |||
There was a problem hiding this comment.
Suggested change
| let(:x5c) { Rails.root.join('engines/commercial/id_azure_active_directory/spec/fixtures/x5c.txt').read } | |
| let(:x5c) { IdAzureActiveDirectory::Engine.root.join('spec/fixtures/x5c.txt').read } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdMethodmodule as the root for all omniauth & verification methodsAuthenticationServiceandVerificationServicefilter this list based onverification?orauth?Changelog
Technical