TAN-2538 Cleanup old initiatives code (Part 2) #9819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…/initiatives_spec.rb
… explanatory comments
…ean up users_spec
…vice NOTIFICATION_CLASSES
…ign files & specs
…on & campaign files & specs
… notification & campaign files & specs
…& campaign files & specs
…aign files & specs
| @@ -24,7 +24,7 @@ class Permission < ApplicationRecord | |||
| PERMITTED_BIES = %w[everyone everyone_confirmed_email users admins_moderators verified].freeze | |||
| ACTIONS = { | |||
| # NOTE: Order of actions in each array is used when using :order_by_action | |||
| nil => %w[visiting following posting_initiative commenting_initiative reacting_initiative attending_event], | |||
There was a problem hiding this comment.
We will also need to delete existing permissions on existing platforms.
| @@ -6,31 +6,21 @@ class NotificationService | |||
| Notifications::CommentDeletedByAdmin, | |||
| Notifications::CommentMarkedAsSpam, | |||
| Notifications::CommentOnIdeaYouFollow, | |||
| Notifications::CommentOnInitiativeYouFollow, | |||
There was a problem hiding this comment.
We will also need to delete existing notifications on existing platforms.
| .order(published_at: :desc) | ||
| .group('union_posts.id, union_posts.published_at') # Remove union_post duplicates | ||
| .select('union_posts.id') | ||
| paged_posts = paginate paged_posts | ||
|
|
||
| # Get the comments, grouped by the corresponding posts | ||
| # page. | ||
| # Get the comments, grouped by the corresponding posts page. |
There was a problem hiding this comment.
TODO: post_id and post_type -> idea or input
| factory :threshold_reached_for_admin, parent: :notification, class: 'Notifications::ThresholdReachedForAdmin' do | ||
| association :post, factory: :initiative | ||
| association :post, factory: :idea |
There was a problem hiding this comment.
TODO: On Notification model: Post -> Idea, PostStatus -> IdeaStatus
| cosponsor2 = create(:user) | ||
| create(:invitation_to_cosponsor_initiative, cosponsors_initiative: cosponsors_initiative) | ||
| initiative.update!(cosponsor_ids: [cosponsor2.id]) | ||
| # it 'removes cosponsors_initiative even when an associated notifcation exists' do |
sebastienhoorens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Does NOT remove
There are some small changes to models, but nothing that will change db data)
postspolymorphysm, as I noticed Sebi already has a PR open for this. TAN-2538 Cleanup old initiatives code (Part 1) #8864Changes
Adds
Notes
public_api- controller, route + spec removed in this PR - only had 16 hits of initiatives endpoint in last 4 weeks (Cloudwatch). All UK, and James thinks:"... they are likely to be Havant using Power BI and I actually think PBI will be just throw a couple of errors in the background but nothing that will cause data issues for them as they were not using initiatives."
See also TAN-2538 Cleanup old initiatives code #8864
Changelog
Technical