Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024-10-11 #9086

Merged
merged 135 commits into from
Oct 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
741823f
WIP add prev and next buttons to idea page
amanda-anderson May 21, 2024
1f4e914
WIP connect to BE and code cleanup
amanda-anderson May 21, 2024
8b9a6f0
WIP new next previous buttons component
amanda-anderson May 21, 2024
2e51d46
Add aria message and hide next previous buttons if no phase context i…
amanda-anderson May 21, 2024
9520188
Merge branch 'master' into TAN-1268-idea-nav-improvements
amanda-anderson May 21, 2024
f7fbd51
Translations updated by CI (extract-intl)
May 21, 2024
a9f8d4e
Make aria message more descriptive
amanda-anderson May 21, 2024
087fa82
Merge branch 'TAN-1268-idea-nav-improvements' of github.com:CitizenLa…
amanda-anderson May 21, 2024
045dd38
Translations updated by CI (extract-intl)
May 21, 2024
e4a9e71
Only append phase_context to URL if present
amanda-anderson May 21, 2024
68a2f50
Merge branch 'TAN-1268-idea-nav-improvements' of github.com:CitizenLa…
amanda-anderson May 21, 2024
f074511
Add phase_context search param to sharing URLs
amanda-anderson May 21, 2024
3466d2c
Clean up code
amanda-anderson May 27, 2024
5bad9fb
Use new mini idea endpoint
amanda-anderson May 27, 2024
b8f8827
Code cleanup
amanda-anderson May 27, 2024
1ae6cec
Fix up endpoint
amanda-anderson May 27, 2024
ddc4684
Merge branch 'master' into TAN-1268-idea-nav-improvements
amanda-anderson May 27, 2024
9d4075c
Merge with master
amanda-anderson May 27, 2024
4c7e689
Translations updated by CI (extract-intl)
May 27, 2024
2f89f6b
Merge with master
amanda-anderson May 27, 2024
cc4fc82
Fixes from code review
amanda-anderson May 31, 2024
0f706b4
Add aria live
amanda-anderson May 31, 2024
3fa678d
Translations updated by CI (extract-intl)
May 31, 2024
7ceb4f7
Merge branch 'master' into TAN-1268-idea-nav-improvements
amanda-anderson Jun 3, 2024
0c121c8
Merge branch 'TAN-1268-idea-nav-improvements' of github.com:CitizenLa…
amanda-anderson Jun 3, 2024
d773098
Add accessibility handling
amanda-anderson Jun 3, 2024
23b46db
Code cleanup
amanda-anderson Jun 3, 2024
f97e35b
Revert line
amanda-anderson Jun 3, 2024
d67dc77
Remove weglot file
amanda-anderson Jun 3, 2024
6a48068
Merge with master
amanda-anderson Jun 10, 2024
2aeb3c6
move permission logic from idea policy to editing_idea action descrip…
sebastienhoorens Sep 5, 2024
0266553
support editing_idea in permission services without having correspond…
sebastienhoorens Sep 5, 2024
d0798f7
remove duplication between project policy show and project permission…
sebastienhoorens Sep 5, 2024
3e57024
remove duplicate project visibility logic in idea update policy + use…
sebastienhoorens Sep 5, 2024
bf9915a
create consistent ideas by factory
sebastienhoorens Sep 5, 2024
0be4e45
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
30d0ac5
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
abdcbb9
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
66436ee
fix offenses
sebastienhoorens Sep 5, 2024
bcb702a
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
ebe340c
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
f70e955
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
5da2211
fixing specs: idea phase issues
sebastienhoorens Sep 5, 2024
7f6f914
move votes exist and published after screening denied reasons from po…
sebastienhoorens Sep 5, 2024
22a7bb3
only check votes and published after screening for editing action
sebastienhoorens Sep 5, 2024
2a434cb
added future_enabled_at for editing_idea
sebastienhoorens Sep 5, 2024
8077175
fix offenses
sebastienhoorens Sep 5, 2024
e2e694e
update -> update! in specs
sebastienhoorens Sep 5, 2024
e16031e
do not require input to be in current phase for editing
sebastienhoorens Sep 9, 2024
a4bb566
fix offenses
sebastienhoorens Sep 9, 2024
503da93
[TAN-2518] Added basic structure of keycloak for ID-Porten
jamesspeake Sep 13, 2024
628082b
Made IdeaPermissionsService for editing_idea consistent with update? …
kogre Sep 14, 2024
c84f240
Merge branch 'bundle-audit/upgrade-omniauth-saml' into TAN-2518-oslo-…
jamesspeake Sep 16, 2024
2f5730b
[TAN-2518] Got tests passing for ID-Porten - awaiting implementation …
jamesspeake Sep 17, 2024
7586188
[TAN-2518] Rubocop fix
jamesspeake Sep 17, 2024
946b11b
[TAN-2518] Added front end components for ID-Porten
jamesspeake Sep 17, 2024
a4b0069
Merge branch 'master' into TAN-2518-oslo-id-porten
jamesspeake Sep 17, 2024
dae1aeb
Idea editting permissions front-end
IvaKop Sep 25, 2024
ce77e92
Added make shortcuts to enable testing of SSO methods
jamesspeake Sep 27, 2024
69ecd0b
Merge in master
amanda-anderson Oct 1, 2024
bbe22a5
Merge in master
amanda-anderson Oct 1, 2024
e9f4f61
Translations updated by CI (extract-intl)
Oct 1, 2024
bb126a1
Fix error in unit test
amanda-anderson Oct 1, 2024
123d67a
Merge branch 'TAN-1268-idea-nav-improvements' of github.com:CitizenLa…
amanda-anderson Oct 1, 2024
8a56a4e
manual merge
sebastienhoorens Oct 1, 2024
9a28cd9
fixing frontend build errors (missing editing_idea action descriptor)
sebastienhoorens Oct 1, 2024
c5d86e6
Remove deadcode
amanda-anderson Oct 1, 2024
d2de677
fix participated in project spec
sebastienhoorens Oct 1, 2024
ec7561a
revert move of moderator guard
sebastienhoorens Oct 1, 2024
c5c3e30
turn policy specs green after restoring behaviour described by accept…
sebastienhoorens Oct 1, 2024
c7ebb5d
WIP move idea nav buttons higher on idea show page
amanda-anderson Oct 2, 2024
ee05cce
Fix accessibility issues
amanda-anderson Oct 3, 2024
2395550
Merge branch 'master' into TAN-1268-idea-nav-improvements
amanda-anderson Oct 7, 2024
bfc8836
Merge branch 'master' into TAN-2518-oslo-id-porten
jamesspeake Oct 7, 2024
dacf5ac
Merge branch 'sso-testing-shortcuts' into TAN-2518-oslo-id-porten
jamesspeake Oct 7, 2024
5379270
Merge branch 'master' into idea-editing-allowed-in-serializer
kogre Oct 7, 2024
7f81f53
[TNA-2518] Got keycloak (ID porten) working
jamesspeake Oct 7, 2024
d1868bc
[TNA-2518] Moved config to admin HQ
jamesspeake Oct 7, 2024
e4d2950
[TNA-2518] Updated logo
jamesspeake Oct 7, 2024
200753d
[TNA-2518] Removed unused code
jamesspeake Oct 7, 2024
0bf1a0b
[TNA-2518] Added ability to test without the feature flag being on
jamesspeake Oct 8, 2024
20d7181
[TNA-2518] Linting
jamesspeake Oct 8, 2024
7930dfd
Make action descriptor and idea policy align for editing_idea
kogre Oct 8, 2024
c9ecde0
Improve performance and explain diverging behavior of editing_idea pe…
kogre Oct 8, 2024
b303d49
TAN-2750 Added specs for idea visibility for cosponsors
kogre Oct 8, 2024
a8d7b8a
TAN-2750 Implement index permissions for ideas for cosponsors
kogre Oct 8, 2024
aa28f5c
Fixed ideas spec for new action descriptor value
kogre Oct 8, 2024
e724e00
Merge branch 'idea-editing-allowed-in-serializer' into TAN-2750-cospo…
kogre Oct 8, 2024
c5a166c
Rubocop fixes
kogre Oct 8, 2024
16c0fab
Fix idea show policy for cosponsors
kogre Oct 8, 2024
6e9d77e
Merge branch 'master' into idea-editing-allowed-in-serializer
kogre Oct 8, 2024
7f7c327
Merge branch 'master' into TAN-1268-idea-nav-improvements
amanda-anderson Oct 9, 2024
452d688
Merge pull request #7950 from CitizenLabDotCo/TAN-1268-idea-nav-impro…
amanda-anderson Oct 9, 2024
a153f23
New translations en.json (French)
cl-dev-bot Oct 9, 2024
333ddf2
New translations en.json (Spanish)
cl-dev-bot Oct 9, 2024
bc5dba3
New translations en.json (Arabic)
cl-dev-bot Oct 9, 2024
da0d623
New translations en.json (Catalan)
cl-dev-bot Oct 9, 2024
0cffbe2
New translations en.json (Danish)
cl-dev-bot Oct 9, 2024
e971960
New translations en.json (German)
cl-dev-bot Oct 9, 2024
ab3ebc1
New translations en.json (Greek)
cl-dev-bot Oct 9, 2024
e458e2d
New translations en.json (Finnish)
cl-dev-bot Oct 9, 2024
da5c21b
New translations en.json (Italian)
cl-dev-bot Oct 9, 2024
111cb6a
New translations en.json (Dutch)
cl-dev-bot Oct 9, 2024
62b12f7
New translations en.json (Norwegian)
cl-dev-bot Oct 9, 2024
04a1fc1
New translations en.json (Polish)
cl-dev-bot Oct 9, 2024
628c113
New translations en.json (Serbian (Cyrillic))
cl-dev-bot Oct 9, 2024
847691a
New translations en.json (Swedish)
cl-dev-bot Oct 9, 2024
41400e7
New translations en.json (Turkish)
cl-dev-bot Oct 9, 2024
146014e
New translations en.json (Portuguese, Brazilian)
cl-dev-bot Oct 9, 2024
e9a084b
New translations en.json (Spanish, Chile)
cl-dev-bot Oct 9, 2024
dbb587e
New translations en.json (Croatian)
cl-dev-bot Oct 9, 2024
e6f5b94
New translations en.json (Latvian)
cl-dev-bot Oct 9, 2024
2a66360
New translations en.json (English, Canada)
cl-dev-bot Oct 9, 2024
3988cec
New translations en.json (English, United Kingdom)
cl-dev-bot Oct 9, 2024
0094480
New translations en.json (Welsh)
cl-dev-bot Oct 9, 2024
d9ed727
New translations en.json (Luxembourgish)
cl-dev-bot Oct 9, 2024
03693d6
New translations en.json (Serbian (Latin))
cl-dev-bot Oct 9, 2024
7ead8ad
New translations en.json (Dutch, Belgium)
cl-dev-bot Oct 9, 2024
cfdb8ce
New translations en.json (English, Ireland)
cl-dev-bot Oct 9, 2024
2a370f2
New translations en.json (French, Belgium)
cl-dev-bot Oct 9, 2024
8d3b17b
New translations en.json (Moroccan Arabic)
cl-dev-bot Oct 9, 2024
6bd0e79
New translations en.json (Acholi)
cl-dev-bot Oct 9, 2024
a7ad27e
Merge pull request #9075 from CitizenLabDotCo/l10n_master
amanda-anderson Oct 9, 2024
6faca5b
Test turning off ssl_mode
jamesspeake Oct 9, 2024
e78531a
Merge pull request #9067 from CitizenLabDotCo/TAN-2750-cosponsor-inpu…
kogre Oct 9, 2024
fa3a201
fix gen_random_uuid()
jamesspeake Oct 9, 2024
c494c45
Merge pull request #8834 from CitizenLabDotCo/idea-editing-allowed-in…
kogre Oct 9, 2024
8febbdd
Merge pull request #9078 from CitizenLabDotCo/js-epic-test
jamesspeake Oct 10, 2024
b028982
[TAN-2518] removed hardcoded redirect URI
jamesspeake Oct 10, 2024
4d57f7c
Fixed following sign-up flow
jamesspeake Oct 10, 2024
68f910e
Merge pull request #9081 from CitizenLabDotCo/fix-following
IvaKop Oct 10, 2024
8c42d7e
New translations en.json (Spanish)
cl-dev-bot Oct 10, 2024
f41afb0
New translations en.json (Spanish, Chile)
cl-dev-bot Oct 10, 2024
0f2a127
Merge pull request #9082 from CitizenLabDotCo/l10n_master
IvaKop Oct 10, 2024
79e0ee2
Merge pull request #8904 from CitizenLabDotCo/TAN-2518-oslo-id-porten
jamesspeake Oct 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing specs: idea phase issues
sebastienhoorens committed Sep 5, 2024
commit bcb702a48e3e2669dd40cac89a3a91f96e64b4c4
2 changes: 1 addition & 1 deletion back/spec/acceptance/ideas_update_spec.rb
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ def public_input_params(spec)

example '[error] Update an idea when there is a posting disabled reason' do
expect_any_instance_of(Permissions::ProjectPermissionsService)
.to receive(:denied_reason_for_action).with('posting_idea').and_return('i_dont_like_you')
.to receive(:denied_reason_for_action).with('editing_idea', anything).and_return('i_dont_like_you')

do_request

3 changes: 3 additions & 0 deletions back/spec/factories/ideas.rb
Original file line number Diff line number Diff line change
@@ -51,6 +51,9 @@
factory :native_survey_response, class: 'Idea' do
association :project, factory: :single_phase_native_survey_project
creation_phase { project.phases.first }
after(:create) do |idea|
idea.phases = [idea.creation_phase] if idea.phases.empty?
end
end
end
end