Merge pull request #9012 from CitizenLabDotCo/TAN-2646-remove-logo-im…

…age-alt-text-from-mails [TAN-2646] Remove alt text from mail logo image
CitizenLabDotCo · Sep 30, 2024 · b1c878e · b1c878e
2 parents e82e64a + 8221005
commit b1c878e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/back/app/views/application/_head.mjml b/back/app/views/application/_head.mjml
@@ -16,10 +16,9 @@
     <mj-all padding="0" font-family="Arial" font-size="15px" line-height="150%" color="black" />
   </mj-attributes>
 
-  <%#  We add underscores to pad the text displayed in the preview so that the body text (including the logo alt text) is not visible %>
   <% unless preheader.empty? %>
     <mj-preview>
-      <%= preheader + ' _____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________'%>
+      <%= preheader + ' - '%>
     </mj-preview>
   <% end %>
 </mj-head>
diff --git a/back/app/views/application/_logo_medium_top.mjml b/back/app/views/application/_logo_medium_top.mjml
@@ -2,7 +2,8 @@
   <mj-column>
     <mj-raw>
       <%= link_to home_url do %>
-        <%= image_tag tenant_logo_url, alt: 'Organization logo' %>
+        <%#  We don't add an alt-text, as this will be visible in mail clients mail list, appended to the preheader text %>
+        <%= image_tag tenant_logo_url %>
       <% end %>
     </mj-raw>
   </mj-column>

diff --git a/back/engines/free/email_campaigns/app/views/email_campaigns/application/_head.mjml b/back/engines/free/email_campaigns/app/views/email_campaigns/application/_head.mjml
@@ -31,7 +31,7 @@
   <%#  We add underscores to pad the text displayed in the preview so that the body text (including the logo alt text) is not visible %>
   <% unless preheader.empty? %>
     <mj-preview>
-      <%= preheader + ' _________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________'%>
+      <%= preheader + ' - '%>
     </mj-preview>
   <% end %>
 </mj-head>