update reftracker & gc

code/__DEFINES/qdel.dm

@@ -13,21 +13,39 @@
 #define QDEL_HINT_HARDDEL_NOW	4
 //defines for the gc_destroyed var
 
+
 #ifdef REFERENCE_TRACKING
 /** If REFERENCE_TRACKING is enabled, qdel will call this object's find_references() verb.
  *
- * Functionally identical to QDEL_HINT_QUEUE if GC_FAILURE_HARD_LOOKUP is not enabled in _compiler_options.dm.
- */
-#define QDEL_HINT_FINDREFERENCE	5
-/// Behavior as QDEL_HINT_FINDREFERENCE, but only if the GC fails and a hard delete is forced.
+ * Functionally identical to [QDEL_HINT_QUEUE] if [GC_FAILURE_HARD_LOOKUP] is not enabled in _compiler_options.dm.
+*/
+#warn TG0001 qdel REFERENCE_TRACKING enabled
+#define QDEL_HINT_FINDREFERENCE 5
+/// Behavior as [QDEL_HINT_FINDREFERENCE], but only if the GC fails and a hard delete is forced.
 #define QDEL_HINT_IFFAIL_FINDREFERENCE 6
 #endif
 
-#define GC_QUEUE_CHECK 1
-#define GC_QUEUE_HARDDELETE 2
-///increase this when adding more steps.
-#define GC_QUEUE_COUNT 2
-#define GC_QUEUED_FOR_QUEUING -1
+// Defines for the ssgarbage queues
+#define GC_QUEUE_FILTER 1 //! short queue to filter out quick gc successes so they don't hang around in the main queue for 5 minutes
+#define GC_QUEUE_CHECK 2 //! main queue that waits 5 minutes because thats the longest byond can hold a reference to our shit.
+#define GC_QUEUE_HARDDELETE 3 //! short queue for things that hard delete instead of going thru the gc subsystem, this is purely so if they *can* softdelete, they will soft delete rather then wasting time with a hard delete.
+#define GC_QUEUE_COUNT 3 //! Number of queues, used for allocating the nested lists. Don't forget to increase this if you add a new queue stage
+
+// Defines for the ssgarbage queue items
+#define GC_QUEUE_ITEM_QUEUE_TIME 1 //! Time this item entered the queue
+#define GC_QUEUE_ITEM_REF 2 //! Ref to the item
+#define GC_QUEUE_ITEM_GCD_DESTROYED 3 //! Item's gc_destroyed var value. Used to detect ref reuse.
+#define GC_QUEUE_ITEM_INDEX_COUNT 3 //! Number of item indexes, used for allocating the nested lists. Don't forget to increase this if you add a new queue item index
+
+// Defines for the time an item has to get its reference cleaned before it fails the queue and moves to the next.
+#define GC_FILTER_QUEUE (1 SECONDS)
+#define GC_CHECK_QUEUE (5 MINUTES)
+#define GC_DEL_QUEUE (10 SECONDS)
+
+#define QDEL_ITEM_ADMINS_WARNED (1<<0) //! Set when admins are told about lag causing qdels in this type.
+#define QDEL_ITEM_SUSPENDED_FOR_LAG (1<<1) //! Set when a type can no longer be hard deleted on failure because of lag it causes while this happens.
+
+// Defines for the [gc_destroyed][/datum/var/gc_destroyed] var.
 #define GC_CURRENTLY_BEING_QDELETED -2
 
 #define QDELING(X) (X.gc_destroyed)

code/__DEFINES/time.dm

@@ -1,7 +1,7 @@
-/// Convert deciseconds to ticks
-#define DS2TICKS(DS) ((DS)/world.tick_lag)
-/// Convert ticks to deciseconds
-#define TICKS2DS(T) ((T) TICKS)
+#define MILLISECONDS *0.01
+
+#define DECISECONDS *1 //the base unit all of these defines are scaled by, because byond uses that as a unit of measurement for some fucking reason
+
 #define SECOND *10
 #define SECONDS *10
 
@@ -17,6 +17,13 @@
 #define TICK *world.tick_lag
 #define TICKS *world.tick_lag
 
+/// Convert deciseconds to ticks
+#define DS2TICKS(DS) ((DS)/world.tick_lag)
+/// Convert ticks to deciseconds
+#define TICKS2DS(T) ((T) TICKS)
+
+#define MS2DS(T) ((T) MILLISECONDS)
+
 #define GAMETIMESTAMP(format, wtime) time2text(wtime, format)
 #define WORLDTIME2TEXT(format) GAMETIMESTAMP(format, world.time)
 #define WORLDTIMEOFDAY2TEXT(format) GAMETIMESTAMP(format, world.timeofday)

code/___compile_options.dm

@@ -123,11 +123,10 @@
 
 #if defined(UNIT_TESTS)
 	//Hard del testing defines
-	// TODO: enable once reftrack is back
-	// #define REFERENCE_TRACKING
-	// #define REFERENCE_TRACKING_DEBUG
-	// #define FIND_REF_NO_CHECK_TICK
-	// #define GC_FAILURE_HARD_LOOKUP
+	#define REFERENCE_TRACKING
+	#define REFERENCE_TRACKING_DEBUG
+	#define FIND_REF_NO_CHECK_TICK
+	#define GC_FAILURE_HARD_LOOKUP
 	//Ensures all early assets can actually load early
 	#define DO_NOT_DEFER_ASSETS
 	//Test at full capacity, the extra cost doesn't matter

code/controllers/configuration/entries/general.dm

@@ -41,3 +41,12 @@
 
 /// Enable or disable the toast notification when the the instance finishes initializing.
 /datum/config_entry/flag/toast_notification_on_init
+
+/datum/config_entry/number/hard_deletes_overrun_threshold
+	integer = FALSE
+	min_val = 0
+	default = 0.5
+
+/datum/config_entry/number/hard_deletes_overrun_limit
+	default = 0
+	min_val = 0