Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update maptext #6867

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

update maptext #6867

wants to merge 10 commits into from

Conversation

LetterN
Copy link
Contributor

@LetterN LetterN commented Nov 16, 2024

About The Pull Request

maptext message text and its related "ticking" is now handled by /datum/maptext and its associated ticker ssrunechat
status display uses its own overlays now for a really smooth text-scroll animation

🆑
add: new fonts used by maptext and status display
tweak: changed maptext default font
tweak: runechat color is based on your "visible" name instead of being randomly picked
tweak: update status display to be really smooth
/:cl:

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 16, 2024
@@ -0,0 +1,14 @@
TIMER_SUBSYSTEM_DEF(runechat)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lohikar will remember this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runechat uses its own timer for qdel callback

silicons
silicons previously approved these changes Nov 16, 2024
@silicons
Copy link
Contributor

idk why i approved a draft but the files looked good

@LetterN LetterN marked this pull request as ready for review November 16, 2024 17:00
Copy link

github-actions bot commented Jan 7, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants