admin stuff update #6855
admin stuff update #6855
Conversation
github-actions
bot
added
the
size/XXL
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| /** | ||
| * Completely occludes a path from view variable interactions. | ||
| */ | ||
| ///Protects a datum from being VV'd or spawned through admin manipulation |
There was a problem hiding this comment.
will dmdoc work when it's placed above the ifndef instead of the define?
| #else | ||
| #define VV_PROTECT(Path) | ||
| #endif | ||
| // we del instead of qdel because for security reasons we must ensure the datum does not exist if Read is called. qdel will not enforce this. | ||
|
|
||
| /** | ||
| * Makes a path read-only to view variables. |
There was a problem hiding this comment.
readonly probably needs /Read() override too
There was a problem hiding this comment.
kinda usless since you can still tag (and potentially) json_encode to get its value
| #define isimage(D) (istype(D, /image)) | ||
|
|
||
| #define isweakref(D) (istype(D, /datum/weakref)) | ||
| GLOBAL_VAR_INIT(magic_appearance_detecting_image, new /image) // appearances are awful to detect safely, but this seems to be the best way ~ninjanomnom |
There was a problem hiding this comment.
this should be reconciled with IS_APPEARANCE macro, seen in typeids
alternatively, switch the typeid macros to IS_TYPEID_* instead of IS_*, since those are implementation defined and definitely not as safe as this (then again; this also seems to be implementation defined, lol)
| // A list of all the special byond lists that need to be handled different by vv | ||
| GLOBAL_LIST_INIT(vv_special_lists, init_special_list_names()) | ||
|
|
||
| /proc/init_special_list_names() | ||
| var/list/output = list() | ||
| var/obj/sacrifice = new | ||
| for(var/varname in sacrifice.vars) | ||
| var/value = sacrifice.vars[varname] | ||
| if(!islist(value)) | ||
| if(!isdatum(value) && hascall(value, "Cut")) | ||
| output += varname | ||
| continue | ||
| if(isnull(locate(REF(value)))) | ||
| output += varname | ||
| return output |
There was a problem hiding this comment.
i honestly really dislike doing this because we do have our own slightly more janky way of doing it, and because imo, doing this in the render loop for vv is better
There was a problem hiding this comment.
wdym render loop? it runs every vv UI call?
|
|
||
| if(VV_COLOR_MATRIX) | ||
| .["value"] = open_color_matrix_editor() | ||
| if(.["value"] == COLOR_MATRIX_IDENTITY) //identity is equivalent to null |
There was a problem hiding this comment.
shouldn't this be ~= for equivalency?
| @@ -26,13 +26,13 @@ export const MESSAGE_TYPE_LOCALCHAT = 'localchat'; | |||
| export const MESSAGE_TYPE_RADIO = 'radio'; | |||
| export const MESSAGE_TYPE_INFO = 'info'; | |||
| export const MESSAGE_TYPE_WARNING = 'warning'; | |||
| export const MESSAGE_TYPE_HELPFUL = 'helpful'; | |||
There was a problem hiding this comment.
is this verified to not be necessary?
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
title