Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sql #6844

Closed
wants to merge 13 commits into from
Closed

update sql #6844

wants to merge 13 commits into from

Conversation

LetterN
Copy link
Contributor

@LetterN LetterN commented Nov 6, 2024

About The Pull Request

title, update sql to support more than 1 connections, add ezdb, remove %PREFIX% on non-prefixed one

Why It's Good For The Game

Changelog

@LetterN LetterN requested a review from Zandario as a code owner November 6, 2024 09:38
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2024
silicons pushed a commit that referenced this pull request Nov 7, 2024
silicons pushed a commit that referenced this pull request Nov 12, 2024
@BlueWildrose BlueWildrose marked this pull request as draft November 13, 2024 03:35
@BlueWildrose
Copy link
Collaborator

setting it to draft so I don't mistakenly testmerge it until @LetterN is confident they fixed the issues caused with this PR

@@ -1,8 +1,6 @@
/**
* make sure to bump schema version and mark changes in database_changelog.md!
*
* default prefix is rp_
Copy link
Contributor

@silicons silicons Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason this is prefixed is not because it's meant to be used as such

rename the file to database_schema-template.sql or something, and generate a new database schema from it with no prefix if you need one

the reason this file is here is so generating the actual .sql's is as easy as find-replacing %_PREFIX_% instead of having to edit two files simultaneously. this results in a lot less typo's.

@silicons
Copy link
Contributor

this'll sound quirky but EZDB should never be automated on the DD instance.
the most we should have is a python script to automatically set up a mariaDB instance.
I think that's good for contributors.
having the DD instance spin it up/down is too far, we want people touching DB to be exposed to the DB itself. DB isn't used on citrp for trivial purposes, we need anyone touching it to know what they're doing.

as a side note; we generally have a policy that server should not require DB to run and operate, for the most part.
the only planned major backends/mechanics that will require DB are

  • persistence

.. and that's about it.
as part of that, data-stores for

  • pictures / photographs
  • paper / faxes / books
  • newscasters
  • map persistence
  • character persistence
  • prototype repositories (which store persistent reagents/materials/etc)

will require DB. they will return null instances if queried when DB is down; this is intentional and fine, as anything not persistent would be loading hardcoded datums in.

@LetterN LetterN closed this Nov 14, 2024
@LetterN LetterN deleted the sequel branch November 14, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants