[s] ensure key config is set for any secure request (#6896)

href exploit bad tgstation/tgstation#88367
Citadel-Station-13 · Dec 5, 2024 · 17bc700 · 17bc700
1 parent 64b809f
commit 17bc700
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/code/datums/world_topic.dm b/code/datums/world_topic.dm
@@ -26,7 +26,7 @@
 	var/require_comms_key = FALSE
 
 /datum/world_topic/proc/TryRun(list/input)
-	key_valid = config && config_legacy.comms_key == input["key"] && (config_legacy.comms_key != initial(config_legacy.comms_key))		//no fucking defaults allowed.
+	key_valid = config_legacy.comms_key == input["key"] && (config_legacy.comms_key != initial(config_legacy.comms_key)) && config_legacy.comms_key	&& input["key"]	//no fucking defaults allowed.
 	//key_valid = config && (CONFIG_GET(string/comms_key) == input["key"])
 	if(require_comms_key && !key_valid)
 		return "Bad Key"