Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get.py for iosxe eigrp folder containing 12 APIs for EIGRPv4 and EIGRPv6 #149

Merged
merged 104 commits into from
Feb 23, 2024

Conversation

cherifimehdi
Copy link
Contributor

Hello,

I noticed there is no get.py file and get apis for ios/iosxe eigrp protocol

I added get.py file at pkgs/sdk-pkg/src/genie/libs/sdk/apis/iosxe/eigrp containing 12 APIs for EIGRPv4 and EIGRPv6:

           * get_eigrp_interfaces
	* get_eigrp_interfaces_v6
	* get_eigrp_interfaces_as
	* get_eigrp_interfaces_as_v6
	* get_eigrp_interfaces_peers
	* get_eigrp_interfaces_peers_v6
	* get_eigrp_interfaces_timers
	* get_eigrp_interfaces_timers_v6
	* get_eigrp_neighbors
	* get_eigrp_neighbors_v6
	* get_eigrp_router_id
	* get_eigrp_router_id_v6

I added all the tests at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/get containing the test results for the 12 APIs in get.py

I added the changelog_add_eigrp_get.py_apis_202329121901.srt file at pkgs/sdk-pkg/changelog folder

Thank you

mock_data for get_eigrp_interfaces api
add test_api_get_eigrp_interfaces.py
add mock_data.yaml for api get_eigrp_interfaces_as
add test_api_get_eigrp_interfaces_as.py
add for get_eigrp_interfaces_as_v6 mock_data.yaml
add api test_api_get_eigrp_interfaces_as_v6
add api test_api_get_eigrp_interfaces_peers
add mock_data.yaml for get_eigrp_interfaces_peers_v6
…_eigrp_interfaces_peers_v6/mock_data_iosxe/tst
…_eigrp_interfaces_peers_v6/mock_data_iosxe directory
…_eigrp_interfaces_peers_v6/mock_data/iosxe/tst
add test_api_get_eigrp_interfaces_peers_v6
…_eigrp_interfaces_timers/mock_data/iosxe/tst
add ttest_api_get_eigrp_interfaces_timers.py
@cherifimehdi
Copy link
Contributor Author

Hello @omehrabi @Taarini @SohanTirpude I updated my PR to include only 06 EIGRP get APIs supporting IPv4 and IPv6 as requested by @omehrabi I merged all get APIs for IPv4 and IPv6.
I updated tests and changelog
Thank you for reviewing my contribution

@Harishv01
Copy link

Hello @omehrabi , Please review this PR

@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi I addressed the change. Just a remark about the variable I think I used the same recommendation and it is significant (ASN: Autonomous System Number)

@cherifimehdi
Copy link
Contributor Author

Sorry @omehrabi I closed by mistake the PR

@cherifimehdi
Copy link
Contributor Author

Now It is open

@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi @Harishv01 This is my change as recommended by @omehrabi
Thank you for reviewing my PR

New Changelog file with change concerning indentation
@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi I have updated Changelog file. Thank you for reviewing my PR and accepting my contribution

@omehrabi omehrabi merged commit d7728d1 into CiscoTestAutomation:master Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants