-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get.py for iosxe eigrp folder containing 12 APIs for EIGRPv4 and EIGRPv6 #149
Conversation
mock_data for get_eigrp_interfaces api
…_eigrp_interfaces/mock_data/iosxe/test
add test_api_get_eigrp_interfaces.py
add mock_data.yaml for api get_eigrp_interfaces_as
…_eigrp_interfaces_as/mock_data/iosxe/tst
add test_api_get_eigrp_interfaces_as.py
add for get_eigrp_interfaces_as_v6 mock_data.yaml
…_eigrp_interfaces_as_v6/mock_data/iosxe/tst
add api test_api_get_eigrp_interfaces_as_v6
…_eigrp_interfaces_peers/mock_data/iosxe/tst
add api test_api_get_eigrp_interfaces_peers
add mock_data.yaml for get_eigrp_interfaces_peers_v6
…_eigrp_interfaces_peers_v6/mock_data_iosxe/tst
…_eigrp_interfaces_peers_v6/mock_data_iosxe directory
…_eigrp_interfaces_peers_v6/mock_data/iosxe/tst
add test_api_get_eigrp_interfaces_peers_v6
…_eigrp_interfaces_timers/mock_data/iosxe/tst
add ttest_api_get_eigrp_interfaces_timers.py
…_eigrp_router_id/mock_data/iosxe/mock_data.yaml
…_eigrp_router_id/mock_data/iosxe/test
Update changelog
Hello @omehrabi @Taarini @SohanTirpude I updated my PR to include only 06 EIGRP get APIs supporting IPv4 and IPv6 as requested by @omehrabi I merged all get APIs for IPv4 and IPv6. |
Hello @omehrabi , Please review this PR |
Here the changes as recommended
Hi @omehrabi I addressed the change. Just a remark about the variable I think I used the same recommendation and it is significant (ASN: Autonomous System Number) |
Sorry @omehrabi I closed by mistake the PR |
Now It is open |
Hi @omehrabi @Harishv01 This is my change as recommended by @omehrabi |
pkgs/sdk-pkg/changelog/changelog_add_eigrp_get.py_apis_202329121901.rst
Outdated
Show resolved
Hide resolved
…21901.rst Delete the old
New Changelog file with change concerning indentation
Hi @omehrabi I have updated Changelog file. Thank you for reviewing my PR and accepting my contribution |
Hello,
I noticed there is no get.py file and get apis for ios/iosxe eigrp protocol
I added get.py file at pkgs/sdk-pkg/src/genie/libs/sdk/apis/iosxe/eigrp containing 12 APIs for EIGRPv4 and EIGRPv6:
I added all the tests at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/get containing the test results for the 12 APIs in get.py
I added the changelog_add_eigrp_get.py_apis_202329121901.srt file at pkgs/sdk-pkg/changelog folder
Thank you