Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223) #312

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223) #312

merged 1 commit into from
Nov 19, 2024

Conversation

akinross
Copy link
Collaborator

@akinross akinross commented Oct 31, 2024 •
edited
Loading

fixes #311

@akinross akinross force-pushed the 311_mso_schema_site_anp_epg_bulk_staticport_update_on_index_shift_fix branch 3 times, most recently from 2fc4409 to 5a1faaa Compare November 4, 2024 09:20
@akinross
[bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema…
8066ab9 
…_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list
@akinross akinross force-pushed the 311_mso_schema_site_anp_epg_bulk_staticport_update_on_index_shift_fix branch from 5a1faaa to 8066ab9 Compare November 4, 2024 09:21
@akinross akinross changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in teh static_ports list (DCNE-223) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223, DCNE-226) Nov 5, 2024
@github-actions github-actions bot changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223, DCNE-226) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223) Nov 5, 2024
@github-actions github-actions bot changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223 DCNE-226) Nov 5, 2024
@akinross akinross changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223 DCNE-226) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223, DCNE-226) Nov 5, 2024
@github-actions github-actions bot changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223, DCNE-226) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223 DCNE-226) Nov 5, 2024
gmicol
gmicol previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross requested a review from samiib November 8, 2024 06:25
shrsr
shrsr previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Nov 11, 2024
View reviewed changes
@akinross akinross dismissed stale reviews from samiib, shrsr, and gmicol via 8066ab9 November 11, 2024 08:50
@akinross akinross force-pushed the 311_mso_schema_site_anp_epg_bulk_staticport_update_on_index_shift_fix branch from 6aa2801 to 8066ab9 Compare November 11, 2024 08:50
@akinross akinross changed the title [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (, ) (DCNE-223 DCNE-226) [bugfix] Fix fex and micro_seg_vlan attributes in resource_mso_schema_site_anp_epg_bulk_staticport to be correctly set when index shift occur in the static_ports list (DCNE-223) Nov 11, 2024
@akinross akinross requested review from gmicol, shrsr and samiib November 11, 2024 08:51
@akinross
Copy link
Collaborator Author

akinross commented Nov 11, 2024 •
edited
Loading

Removed the logic for the fex vpc issue, and will create a new PR for this. Think datasource and single equivalent resource/datasource should also be adjusted

shrsr
shrsr approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib self-requested a review November 12, 2024 03:07
gmicol
gmicol approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 0f4cc1a into CiscoDevNet:master Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mso_schema_site_anp_epg_bulk_staticport doesnt update fex field correctly (DCNE-223)
5 participants
@akinross @shrsr @samiib @gmicol @lhercot