[minor_change] Bump required go version to go v1.21 (DCNE-216) #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
akinross
force-pushed
the
bump_go_version
branch
from
62c3bef to
5b8b42f
Compare
akinross
force-pushed
the
bump_go_version
branch
from
5b8b42f to
69eb5d0
Compare
github-actions
bot
changed the title
samiib
approved these changes
Oct 24, 2024
What do you mean concerns about vendor files? |
@akinross I was mostly wondering why so many got removed. I think it could be a dependency optimisation in newer versions of Go. Dependencies that are not direct dependencies are indirect so it appears to be de-duplicating them. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.