Fix undeployment on destroy for resource mso_schema_site. (DCNE-55) #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deployed for resource mso_schema_site.
github-actions
bot
changed the title
gmicol
changed the title
gmicol
changed the title
…e example for resource schema_site.
gmicol
force-pushed
the
mso_schema_site-deletion-bugfix
branch
from
ffca548 to
9c8df05
Compare
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
…ns for deployment status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
The Delete function will first check if template is deployed on site before being undeployed. If not deployed, It will now properly skip the undeployment phase which previously led to the resource being removed from State but not from MSO.