[minor_changes] Fixed idempotency on site service graph. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvitha-jain
requested review from
sajagana,
akinross,
lhercot,
shrsr,
samiib and
gmicol
and removed request for
sajagana
samiib
requested changes
Jul 24, 2024
anvitha-jain
force-pushed
the
site_contrct_sg
branch
from
8e33ded to
77bf6ce
Compare
akinross
requested changes
Aug 1, 2024
… it has to be verified at upper level.
anvitha-jain
dismissed stale reviews from shrsr, sajagana, and samiib
via
6840a42
lhercot
requested changes
Aug 6, 2024
anvitha-jain
dismissed stale reviews from sajagana, akinross, shrsr, and samiib
via
6c17e25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idempotency issue was fixed by adding computed to the template contract resource.
Additional validation checks are added in custom diff to prevent resource_mso_schema_site_service_graph from throwing an error (service_graph not found).