Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add resources and datasources to support qosDot1PClass and qosDscpClass and expose them in existing aci_custom_qos_policy resource and datasource as children (DCNE-35) #1296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[minor_change] Add resources and datasources to support qosDot1PClass and qosDscpClass and expose them in existing aci_custom_qos_policy resource and datasource as children (DCNE-35) #1296

wants to merge 1 commit into from

Conversation

akinross
Copy link
Collaborator

fixes #1267

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.53727% with 218 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (7ecea9c) to head (36cb84d).

Files with missing lines Patch % Lines
internal/provider/resource_aci_dot1p_classifier.go 85.66% 67 Missing and 25 partials ⚠️
...rnal/provider/resource_aci_dscp_to_priority_map.go 85.66% 67 Missing and 25 partials ⚠️
...nternal/provider/resource_aci_custom_qos_policy.go 98.57% 8 Missing and 4 partials ⚠️
...ernal/provider/data_source_aci_dot1p_classifier.go 92.30% 9 Missing and 2 partials ⚠️
...l/provider/data_source_aci_dscp_to_priority_map.go 92.30% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   85.45%   85.67%   +0.21%     
==========================================
  Files         125      129       +4     
  Lines       70689    73261    +2572     
==========================================
+ Hits        60409    62763    +2354     
- Misses       8324     8484     +160     
- Partials     1956     2014      +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmicol
gmicol approved these changes Nov 19, 2024 •
edited
Loading
View reviewed changes
gmicol
gmicol requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried to see what happens with these class objects when priority is set to unspecified?

@akinross
Copy link
Collaborator Author

have you tried to see what happens with these class objects when priority is set to unspecified?

just double checked and it sets to unspecified for both classes, also checked the target_cos attribute

@akinross akinross requested a review from gmicol November 19, 2024 19:55
shrsr
shrsr requested changes Nov 19, 2024
View reviewed changes
docs/data-sources/custom_qos_policy.md Outdated Show resolved Hide resolved
docs/data-sources/custom_qos_policy.md Outdated Show resolved Hide resolved
docs/data-sources/custom_qos_policy.md Outdated Show resolved Hide resolved
docs/data-sources/custom_qos_policy.md Outdated Show resolved Hide resolved
docs/data-sources/custom_qos_policy.md Outdated Show resolved Hide resolved
docs/data-sources/dscp_to_priority_map.md Outdated Show resolved Hide resolved
docs/data-sources/dscp_to_priority_map.md Outdated Show resolved Hide resolved
docs/data-sources/dscp_to_priority_map.md Outdated Show resolved Hide resolved
docs/data-sources/dscp_to_priority_map.md Outdated Show resolved Hide resolved
docs/data-sources/dscp_to_priority_map.md Outdated Show resolved Hide resolved
@akinross akinross force-pushed the 1267_qos_custom_policy_children branch from 03a8ac3 to 90d41a5 Compare November 20, 2024 06:57
@akinross akinross requested a review from shrsr November 20, 2024 07:02
shrsr
shrsr previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana requested changes Nov 28, 2024
View reviewed changes
gen/definitions/classes.yaml Outdated
qosDscpClass:
resource_name: "dscp_to_priority_map"
ui_locations:
- "Tenants -> Policies -> Protocol -> Custom QoS -> DSCP to priority ap"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "Tenants -> Policies -> Protocol -> Custom QoS -> DSCP to priority ap"
- "Tenants -> Policies -> Protocol -> Custom QoS -> DSCP to priority map"

@akinross akinross dismissed stale reviews from gmicol and shrsr via 51407b9 November 28, 2024 16:19
@akinross akinross force-pushed the 1267_qos_custom_policy_children branch from 76d99ba to 51407b9 Compare November 28, 2024 16:19
shrsr
shrsr previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross
[minor_change] Add resources and datasources to support qosDot1PClass…
36cb84d 
… and qosDscpClass and expose them in aci_custom_qos_policy resource and datasource as children
@akinross akinross dismissed stale reviews from samiib and gmicol via 36cb84d December 19, 2024 09:15
@akinross akinross dismissed stale reviews from sajagana and shrsr via 36cb84d December 19, 2024 09:15
@akinross akinross force-pushed the 1267_qos_custom_policy_children branch from 51407b9 to 36cb84d Compare December 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol left review comments

@samiib samiib samiib left review comments

@sajagana sajagana sajagana left review comments

@shrsr shrsr shrsr left review comments

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resources/data sources for qosDot1PClass and qosDscpClass (DCNE-35)
6 participants
@akinross @codecov-commenter @shrsr @sajagana @samiib @gmicol