Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Revised converter and added template #1273

Closed
wants to merge 5 commits into from

Conversation

harismalk
Copy link
Collaborator

@harismalk harismalk commented Aug 16, 2024

No description provided.

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong with your branch.

  1. All the legacy-docs got deleted.
  2. The built binary of the provider is commited which doesn't need to be.
  3. The build binary of the converter doesn't need to be commited either. It should be built as part of the CI.
  4. Your test plan and data shouldn't be commited either.

@@ -0,0 +1,31 @@
7/29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you intended to commit your own notes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I will update my PR with these revisions.

@lhercot lhercot closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants