Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated code diff check to CI #1213

Merged
merged 5 commits into from
May 14, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented May 9, 2024

Removed build ignore filter from generator.go which allowed the vendor packages to be populated correctly.

Fixes #1178

@samiib samiib self-assigned this May 9, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@samiib samiib mentioned this pull request May 9, 2024
@samiib samiib force-pushed the 1178_tf_ci_testing_pipeline_diff branch from d61fade to 3cfbf68 Compare May 9, 2024 12:04
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 0b33a73 into CiscoDevNet:master May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI testing for terraform
5 participants