Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New resources and datasources for Netflow Monitor Policies. #1208

Merged
merged 11 commits into from
May 17, 2024
Merged

Add New resources and datasources for Netflow Monitor Policies. #1208

merged 11 commits into from
May 17, 2024

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Apr 30, 2024

Resolved issue #990

@gmicol gmicol self-assigned this Apr 30, 2024
@gmicol gmicol linked an issue Apr 30, 2024 that may be closed by this pull request
Create a new resource and a data source for Netflow monitors #990
Closed
@gmicol gmicol force-pushed the aci_netflow_monitor_pol branch from 068b167 to b832009 Compare April 30, 2024 21:27
gmicol

This comment was marked as resolved.

Sign in to view

samiib
samiib reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to rebase off master. Run go generate then run go mod tidy and go mod vendor.
Looks like a new module is added but not saved in the vendor folder.

@gmicol
Copy link
Collaborator Author

gmicol commented May 2, 2024

@samiib, Thanks for that. I made the changes.

@gmicol gmicol requested a review from samiib May 2, 2024 23:24
sajagana
sajagana requested changes May 3, 2024
View reviewed changes
gen/generator.go Outdated Show resolved Hide resolved
@gmicol gmicol force-pushed the aci_netflow_monitor_pol branch from 54477a7 to b07d16a Compare May 3, 2024 20:34
@gmicol gmicol requested a review from sajagana May 3, 2024 20:35
akinross
akinross requested changes May 6, 2024
View reviewed changes
docs/data-sources/netflow_monitor_policy.md Outdated Show resolved Hide resolved
gen/definitions/classes.yaml Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
internal/provider/data_source_aci_netflow_monitor_policy.go Show resolved Hide resolved
@lhercot lhercot requested a review from akinross May 14, 2024 10:04
gmicol added 8 commits May 14, 2024 13:08
@gmicol
[minor_change] Generate resources and datasources for netflowMonitorPol.
df010c7
@gmicol
[minor_change] Generate resource and datasource for netflowRsMonitorT…
7651e8c 
…oExporter. Modify Templates and generator to overwrite default values for properties (includes parent_dn). Modify test templates to handle 1:1 relationships children.
@gmicol
[ignore] Generate with properties modifications (forgot to do go gene…
e1767d6 
…rate...)
@gmicol
[minor_change] Modify the templates for testvars and resource_test.go…
a7fc859 
… in order to prevent the removal of none deletable children.
@gmicol
[ignore] Save new modules in vendor folder.
baf8afa
@gmicol
[ignore] Change Computed to Optional for parent_dn indatasource.go te…
a645921 
…mplate if parent_dn is set to default in properties.
@gmicol
[ignore] Change name of template function from SetDefault to GetDefau…
8c103d0 
…ltValues in generator and templates.
@gmicol
[ignore] quick renaming for template function GetDefaultValues.
f147a4d
@gmicol gmicol force-pushed the aci_netflow_monitor_pol branch from b07d16a to f9a524e Compare May 14, 2024 18:13
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.16392% with 148 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master@0b33a73). Learn more about missing BASE report.

Files Patch % Lines
...al/provider/resource_aci_netflow_monitor_policy.go 87.09% 46 Missing and 26 partials ⚠️
...vider/resource_aci_relation_to_netflow_exporter.go 83.75% 37 Missing and 21 partials ⚠️
...provider/data_source_aci_netflow_monitor_policy.go 92.95% 7 Missing and 3 partials ⚠️
...er/data_source_aci_relation_to_netflow_exporter.go 91.30% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1208   +/-   ##
=========================================
  Coverage          ?   87.02%           
=========================================
  Files             ?       41           
  Lines             ?    10708           
  Branches          ?        0           
=========================================
  Hits              ?     9319           
  Misses            ?      948           
  Partials          ?      441

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol gmicol requested a review from akinross May 15, 2024 18:55
akinross
akinross previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr requested changes May 16, 2024
View reviewed changes
docs/resources/annotation.md Show resolved Hide resolved
docs/data-sources/tag.md Show resolved Hide resolved
docs/data-sources/annotation.md Show resolved Hide resolved
docs/resources/tag.md Show resolved Hide resolved
gen/templates/resource_test.go.tmpl Outdated Show resolved Hide resolved
gen/templates/resource_test.go.tmpl Outdated Show resolved Hide resolved
@gmicol gmicol dismissed stale reviews from sajagana and akinross via 155ca90 May 16, 2024 19:22
@gmicol gmicol requested review from shrsr, akinross and sajagana May 16, 2024 19:22
akinross
akinross approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit b64cb9a into CiscoDevNet:master May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees

@gmicol gmicol

Labels
enhancement new-data-source new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new resource and a data source for Netflow monitors
7 participants
@gmicol @codecov-commenter @lhercot @shrsr @akinross @sajagana @samiib