Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aci_l3out_node_sid_profile resource and data-source files #1207

Merged
merged 3 commits into from
May 17, 2024

Conversation

sajagana
Copy link
Collaborator

No description provided.

docs/data-sources/tag.md Outdated Show resolved Hide resolved
@samiib samiib self-requested a review April 30, 2024 05:38
samiib
samiib previously approved these changes Apr 30, 2024
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Apr 30, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/data-sources/l3out_node_sid_profile.md Outdated Show resolved Hide resolved
docs/data-sources/l3out_node_sid_profile.md Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from gmicol and samiib via 44c00e0 May 6, 2024 15:46
@sajagana sajagana force-pushed the 1175_mplsNodeSidP branch from 40f8213 to 44c00e0 Compare May 6, 2024 15:46
@sajagana sajagana requested review from gmicol, samiib and akinross May 6, 2024 15:47
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase to make CI pass

@sajagana sajagana force-pushed the 1175_mplsNodeSidP branch from 44c00e0 to d82eaa0 Compare May 7, 2024 07:18
@sajagana sajagana requested a review from akinross May 7, 2024 07:28
akinross
akinross previously approved these changes May 7, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes May 14, 2024
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes May 16, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes May 17, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from shrsr and gmicol via 5eaade7 May 17, 2024 14:37
@sajagana sajagana dismissed stale reviews from samiib and akinross via 5eaade7 May 17, 2024 14:37
@sajagana sajagana force-pushed the 1175_mplsNodeSidP branch from d82eaa0 to 5eaade7 Compare May 17, 2024 14:37
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 6f45104 into CiscoDevNet:master May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add resource and datasource to support mplsNodeSidP
7 participants