-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files (DCNE-153) #1204
Conversation
a5b060b
to
bc57c5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bc57c5c
to
e9d0f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a fail test for relation_to_route_control_profile data source. Do you have this error happening locally or is it a CI issue?
Error: Failed to read aci_relation_to_route_control_profile data source
I think this is a new test that is consistently failing. I re-ran the CI and its correctly picking up the failed test. Unless there is some environment difference because the CI is run on Ubuntu latest. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
+ Coverage 87.03% 87.16% +0.13%
==========================================
Files 43 47 +4
Lines 11223 12353 +1130
==========================================
+ Hits 9768 10768 +1000
- Misses 991 1077 +86
- Partials 464 508 +44 ☔ View full report in Codecov by Sentry. |
…te_control_profile - resource and data-source files
…trol_profile to fix the sanity failure
…ource_example_all_attributes.tf.tmpl
a863a75
to
eb2a16b
Compare
…ml file and added logic to exclude resource creation in the generator.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most examples, the parent resource is missing, could you please add them either as a resource or datasource
No description provided.