Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Terraform CI for build and integration tests #1203

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Added Terraform CI for build and integration tests #1203

merged 7 commits into from
Apr 30, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Apr 24, 2024 •
edited
Loading

Part 1 Terraform CI:

  • Go Format check
  • Go Vendor check
  • Go Build check
  • Terraform Acceptance Tests for APIC v5.2 & v6.0

samiib
samiib commented Apr 24, 2024
View reviewed changes
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@samiib samiib self-assigned this Apr 24, 2024
@samiib samiib requested a review from lhercot April 24, 2024 02:31
@samiib samiib mentioned this pull request Apr 24, 2024
Closed
lhercot
lhercot requested changes Apr 24, 2024
View reviewed changes
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@samiib samiib force-pushed the 1178_tf_ci_testing_pipeline branch from 069e70b to dac812d Compare April 24, 2024 04:55
akinross
akinross reviewed Apr 24, 2024
View reviewed changes
.github/workflows/checks.yml Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@samiib samiib changed the title [ignore] Added Terraform CI for build and integration tests [ignore] [WIP] Added Terraform CI for build and integration tests Apr 24, 2024
@samiib samiib force-pushed the 1178_tf_ci_testing_pipeline branch from b6c5ac6 to 3c3a077 Compare April 28, 2024 23:04
@samiib samiib changed the title [ignore] [WIP] Added Terraform CI for build and integration tests Added Terraform CI for build and integration tests Apr 29, 2024
@samiib samiib force-pushed the 1178_tf_ci_testing_pipeline branch from 51d4ff1 to 88d69f3 Compare April 29, 2024 10:51
lhercot
lhercot approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 40e545f into CiscoDevNet:master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@akinross akinross Awaiting requested review from akinross akinross is a code owner

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Assignees

@samiib samiib

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samiib @lhercot @akinross