Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of new generated resource and data source for pkiTP (DCNE-143 DCNE-142) #1145

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Addition of new generated resource and data source for pkiTP (DCNE-143 DCNE-142) #1145

merged 1 commit into from
Oct 3, 2024

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Jan 23, 2024

No description provided.

@shrsr shrsr self-assigned this Jan 23, 2024
This was linked to issues Jan 23, 2024
APIC Certificate Import Support - (DCNE-145) #1072
Closed
Create a resource to configure "Certificate Authority - pkiTP" object for the Azure CNC (DCNE-143) #1134
Closed
Create a resource to configure "Key Ring - pkiKeyRing" object for the Azure CNC (DCNE-142) #1135
Closed
akinross
akinross requested changes Mar 8, 2024
View reviewed changes
docs/data-sources/certificate_authority.md Outdated Show resolved Hide resolved
docs/data-sources/certificate_authority.md Outdated Show resolved Hide resolved
docs/resources/annotation.md Outdated Show resolved Hide resolved
docs/resources/annotation.md Outdated Show resolved Hide resolved
docs/resources/certificate_authority.md Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Outdated Show resolved Hide resolved
@shrsr shrsr removed a link to an issue Mar 12, 2024
APIC Certificate Import Support - (DCNE-145) #1072
Closed
@shrsr shrsr mentioned this pull request Mar 12, 2024
Closed
@shrsr shrsr requested a review from akinross March 16, 2024 21:22
akinross
akinross requested changes Mar 20, 2024
View reviewed changes
docs/data-sources/certificate_authority.md Outdated Show resolved Hide resolved
docs/data-sources/certificate_authority.md Outdated Show resolved Hide resolved
docs/data-sources/certificate_authority.md Outdated Show resolved Hide resolved
docs/data-sources/key_ring.md Outdated Show resolved Hide resolved
docs/data-sources/key_ring.md Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_annotation.go Outdated Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority.go Show resolved Hide resolved
internal/provider/resource_aci_rest_managed_test.go Outdated Show resolved Hide resolved
@shrsr shrsr requested a review from akinross March 27, 2024 19:58
lhercot
lhercot requested changes Mar 27, 2024
View reviewed changes
gen/definitions/classes.yaml Show resolved Hide resolved
gen/templates/testvars.yaml.tmpl Outdated Show resolved Hide resolved
examples/data-sources/aci_certificate_authority/data-source.tf Outdated Show resolved Hide resolved
examples/data-sources/aci_key_ring/data-source.tf Outdated Show resolved Hide resolved
examples/resources/aci_certificate_authority/resource-all-attributes.tf Outdated Show resolved Hide resolved
gen/templates/resource_example.tf.tmpl Outdated Show resolved Hide resolved
gen/templates/resource_example_all_attributes.tf.tmpl Outdated Show resolved Hide resolved
gen/templates/resource_example_all_attributes.tf.tmpl Outdated Show resolved Hide resolved
gen/templates/resource_example_all_attributes.tf.tmpl Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
samiib
samiib requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get a chance can you please also rebase before regenerating again.

gen/definitions/properties.yaml Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/generator.go Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/templates/datasource.md.tmpl Outdated Show resolved Hide resolved
gen/templates/testvars.yaml.tmpl Show resolved Hide resolved
@shrsr shrsr requested a review from lhercot March 28, 2024 13:31
sajagana
sajagana requested changes Mar 28, 2024
View reviewed changes
gen/generator.go Show resolved Hide resolved
internal/provider/resource_aci_certificate_authority_test.go Outdated Show resolved Hide resolved
@shrsr shrsr requested review from sajagana and samiib March 29, 2024 15:19
anvitha-jain
anvitha-jain previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@shrsr shrsr dismissed stale reviews from sajagana, gmicol, and anvitha-jain via fbb66bb April 2, 2024 16:21
lhercot
lhercot reviewed Sep 13, 2024
View reviewed changes
docs/resources/key_ring.md Outdated Show resolved Hide resolved
lhercot
lhercot reviewed Sep 13, 2024
View reviewed changes
docs/resources/key_ring.md Outdated Show resolved Hide resolved
lhercot
lhercot reviewed Sep 13, 2024
View reviewed changes
gen/generator.go Outdated Show resolved Hide resolved
@github-actions github-actions bot changed the title Addition of new generated resource and data source for pkiTP (DCNE-142 DCNE-143) Addition of new generated resource and data source for pkiTP (DCNE-143 DCNE-142) Sep 20, 2024
samiib
samiib approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit baaa506 into CiscoDevNet:master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@shrsr @codecov-commenter @akinross @lhercot @anvitha-jain @sajagana @samiib @gmicol