[ignore] fixed unecessary validators for resource

CiscoDevNet · Jun 24, 2024 · 90dfeb1 · 90dfeb1
1 parent 886cbdf
commit 90dfeb1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 17 deletions.
diff --git a/docs/resources/remote_site_id_mappings.md b/docs/resources/remote_site_id_mappings.md
@@ -103,9 +103,7 @@ All examples for the Remote Site Id Mappings resource can be found in the [examp
 * `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation.
 * `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object.
 * `remote_vrf_pc_tag` (remoteCtxPcTag) - (string) Remote context's *pcTag*, mapping required for default route case.
-  - Valid Values: `any`.
 * `remote_pc_tag` (remotePcTag) - (string) Remote Class ID.
-  - Valid Values: `any`.
 
 * `annotations` - (list) A list of Annotations (ACI object [tagAnnotation](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/tagAnnotation/overview)). Annotations can also be configured using a separate [aci_annotation](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/annotation) resource. This attribute is supported in ACI versions: 3.2(1l) and later.
 

diff --git a/gen/definitions/properties.yaml b/gen/definitions/properties.yaml
@@ -200,7 +200,7 @@ fvSiteAssociated:
   default_values:
     site_id: "0"
   resource_required:
-      site_id: "0"
+    - "site_id"
   test_values:
     all:
        site_id: "0" 
@@ -224,7 +224,7 @@ fvRemoteId:
     siteId: "A number between 0 and 1000 to identify the remote site being associated with the primary site"
   test_values:
     all:
-      site_id: "0" 
+      site_id: "102" 
       remote_vrf_pc_tag: "16386"
       remote_pc_tag: "2818057"
     default:
@@ -234,9 +234,9 @@ fvRemoteId:
     resource_required:
       site_id: "0"
   resource_required:
-      siteId: "0"
+    - "site_id"
   default_values:
-    siteId: "0"
+    siteId: "102"
   parents:
     - class_name: "fvSiteAssociated"
       parent_dependency: "fvCtx"

diff --git a/gen/generator.go b/gen/generator.go
@@ -1105,6 +1105,9 @@ func (m *Model) SetClassProperties(classDetails interface{}) {
 			if propertyValue.(map[string]interface{})["validValues"] != nil {
 				for _, details := range propertyValue.(map[string]interface{})["validValues"].([]interface{}) {
 					validValue := details.(map[string]interface{})["localName"].(string)
+					if propertyName == "remoteCtxPcTag" || propertyName == "remotePcTag" {
+						validValue = "defaultValue"
+					}
 					if validValue != "defaultValue" {
 						property.ValidValues = append(property.ValidValues, validValue)
 					}

diff --git a/gen/testvars/fvRemoteId.yaml b/gen/testvars/fvRemoteId.yaml
@@ -31,7 +31,7 @@ all:
   owner_tag: "owner_tag"
   remote_vrf_pc_tag: "16386"
   remote_pc_tag: "2818057"
-  site_id: "0"
+  site_id: "102"
 
 children:
   annotations:

diff --git a/internal/provider/resource_aci_remote_site_id_mappings.go b/internal/provider/resource_aci_remote_site_id_mappings.go
diff --git a/internal/provider/resource_aci_remote_site_id_mappings_test.go b/internal/provider/resource_aci_remote_site_id_mappings_test.go