[minor_change] Add service_bd_routing_disable attribute to aci_bridge…

…_domain resource and datasource
CiscoDevNet · Dec 19, 2024 · 14debd3 · 14debd3
1 parent 7ecea9c
commit 14debd3
Show file tree

Hide file tree

Showing 9 changed files with 114 additions and 11 deletions.
diff --git a/docs/data-sources/bridge_domain.md b/docs/data-sources/bridge_domain.md
@@ -69,6 +69,7 @@ data "aci_bridge_domain" "example_tenant" {
 * `name_alias` (nameAlias) - (string) The name alias of the Bridge Domain object.
 * `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation.
 * `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object.
+* `service_bd_routing_disable` (serviceBdRoutingDisable) - (string) Disable Routing on service BD.
 * `bridge_domain_type` (type) - (string) The domain type of the Bridge Domain object.
 * `unicast_routing` (unicastRoute) - (string) Enables L3 routing and endpoint IP learning for the Bridge Domain object.
 * `l2_unknown_unicast_flooding` (unkMacUcastAct) - (string) The forwarding method for unknown layer 2 destinations.

diff --git a/docs/resources/bridge_domain.md b/docs/resources/bridge_domain.md
@@ -70,6 +70,7 @@ resource "aci_bridge_domain" "full_example_tenant" {
   name_alias                         = "name_alias_1"
   owner_key                          = "owner_key_1"
   owner_tag                          = "owner_tag_1"
+  service_bd_routing_disable         = "no"
   bridge_domain_type                 = "fc"
   unicast_routing                    = "no"
   l2_unknown_unicast_flooding        = "proxy"
@@ -383,6 +384,9 @@ All examples for the Bridge Domain resource can be found in the [examples](https
 * `name_alias` (nameAlias) - (string) The name alias of the Bridge Domain object.
 * `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation.
 * `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object.
+* `service_bd_routing_disable` (serviceBdRoutingDisable) - (string) Disable Routing on service BD.
+  - Default: `no`
+  - Valid Values: `no`, `yes`.
 * `bridge_domain_type` (type) - (string) The domain type of the Bridge Domain object.
   - Default: `regular`
   - Valid Values: `fc`, `regular`.

diff --git a/examples/resources/aci_bridge_domain/resource-all-attributes.tf b/examples/resources/aci_bridge_domain/resource-all-attributes.tf
@@ -23,6 +23,7 @@ resource "aci_bridge_domain" "full_example_tenant" {
   name_alias                         = "name_alias_1"
   owner_key                          = "owner_key_1"
   owner_tag                          = "owner_tag_1"
+  service_bd_routing_disable         = "no"
   bridge_domain_type                 = "fc"
   unicast_routing                    = "no"
   l2_unknown_unicast_flooding        = "proxy"

diff --git a/gen/meta/fvBD.json b/gen/meta/fvBD.json
@@ -2046,7 +2046,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "34472",
                     "propLocalId": "8158",
-                    "label": "Optimize Wan Bandwidth between sites",
+                    "label": "Optimize Wan Bandwidth Between Sites",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -2176,7 +2176,7 @@
                     "isConfigurable": false,
                     "propGlobalId": "1691",
                     "propLocalId": "859",
-                    "label": "bcastP",
+                    "label": "Broadcast Policy",
                     "baseType": "address:IPv4",
                     "modelType": "mcast:Group",
                     "needsPropDelimiters": false,
@@ -2251,7 +2251,7 @@
                     "isConfigurable": false,
                     "propGlobalId": "26448",
                     "propLocalId": "153",
-                    "label": "configIssues",
+                    "label": "Configuration Issues",
                     "baseType": "scalar:Bitmask64",
                     "modelType": "fv:BDConfIssuesType",
                     "needsPropDelimiters": false,
@@ -2606,7 +2606,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "30545",
                     "propLocalId": "7595",
-                    "label": "Allow BUM traffic between sites",
+                    "label": "Allow BUM Traffic Between Sites",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -2653,7 +2653,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "33178",
                     "propLocalId": "7928",
-                    "label": "Allow l2Stretch between sites",
+                    "label": "Allow L2Stretch Between Sites",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -2697,7 +2697,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "21254",
                     "propLocalId": "5433",
-                    "label": "Ip Learning",
+                    "label": "IP Learning",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -2744,7 +2744,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "47406",
                     "propLocalId": "10834",
-                    "label": "ipv6 Multicast Allow",
+                    "label": "IPv6 Multicast Allow",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -2854,7 +2854,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "20851",
                     "propLocalId": "5375",
-                    "label": "Limit IP learning to BD subnets only",
+                    "label": "Limit IP Learning to BD Subnets",
                     "baseType": "scalar:Bool",
                     "modelType": "scalar:Bool",
                     "needsPropDelimiters": false,
@@ -3380,7 +3380,7 @@
                     "isConfigurable": false,
                     "propGlobalId": "1695",
                     "propLocalId": "551",
-                    "label": "pcTag",
+                    "label": "PC Tag",
                     "baseType": "scalar:Uint32",
                     "modelType": "vz:GPCTag",
                     "needsPropDelimiters": false,
@@ -3445,7 +3445,7 @@
                     "isConfigurable": false,
                     "propGlobalId": "1694",
                     "propLocalId": "1",
-                    "label": "scope",
+                    "label": "Scope",
                     "baseType": "scalar:Uint32",
                     "modelType": "fv:ScopeId",
                     "needsPropDelimiters": false,
@@ -3503,6 +3503,56 @@
                     "isDeprecated": false,
                     "isHidden": false
                 },
+                "serviceBdRoutingDisable": {
+                    "versions": "6.0(4c)-",
+                    "comment": [
+                         "Disable Routing on service BD"
+                    ],
+                    "isConfigurable": true,
+                    "propGlobalId": "70465",
+                    "propLocalId": "15461",
+                    "label": "Disable Routing on Service BD",
+                    "baseType": "scalar:Bool",
+                    "modelType": "scalar:Bool",
+                    "needsPropDelimiters": false,
+                    "uitype": "boolean",
+                    "createOnly": false,
+                    "readWrite": true,
+                    "readOnly": false,
+                    "isNaming": false,
+                    "secure": false,
+                    "implicit": false,
+                    "mandatory": false,
+                    "isOverride": false,
+                    "isLike": false,
+                    "validValues": [
+                         { "value": "no", "localName": "defaultValue",
+                             "platformFlavors": [
+
+                             ],
+                             "comment": [
+                                 "By default, routing is enabled on service BD"
+                             ],
+                             "label": " "},
+                         { "value": "false", "localName": "no",
+                             "platformFlavors": [
+
+                             ],
+                             "label": "No "},
+                         { "value": "true", "localName": "yes",
+                             "platformFlavors": [
+
+                             ],
+                             "label": "Yes "}
+                    ],
+                    "default": "no",
+                    "platformFlavors": [
+
+                    ],
+                    "isNxosConverged": false,
+                    "isDeprecated": false,
+                    "isHidden": false
+                },
                 "status": {
                     "versions": "1.0(1e)-",
                     "comment": [
@@ -3689,7 +3739,7 @@
                     "isConfigurable": true,
                     "propGlobalId": "1696",
                     "propLocalId": "886",
-                    "label": "Unknown Mac Unicast Action",
+                    "label": "Unknown MAC Unicast Action",
                     "baseType": "scalar:Enum8",
                     "modelType": "l2:UnkMacUcastAct",
                     "needsPropDelimiters": false,

diff --git a/gen/testvars/fvBD.yaml b/gen/testvars/fvBD.yaml
@@ -35,6 +35,8 @@ default:
       pim_ipv6: "no"
     5.2(5c):
       drop_arp_with_multicast_smac: "yes"
+    6.0(4c):
+      service_bd_routing_disable: "no"
 
 datasource_non_existing:
   name: "non_existing_name"
@@ -77,6 +79,8 @@ all:
       pim_ipv6: "no"
     5.2(5c):
       drop_arp_with_multicast_smac: "no"
+    6.0(4c):
+      service_bd_routing_disable: "no"
 
 children:
   legacy_mode:

diff --git a/internal/provider/data_source_aci_bridge_domain.go b/internal/provider/data_source_aci_bridge_domain.go
diff --git a/internal/provider/data_source_aci_bridge_domain_test.go b/internal/provider/data_source_aci_bridge_domain_test.go
diff --git a/internal/provider/resource_aci_bridge_domain.go b/internal/provider/resource_aci_bridge_domain.go
diff --git a/internal/provider/resource_aci_bridge_domain_test.go b/internal/provider/resource_aci_bridge_domain_test.go