Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XML file upload pre-change (DCNE-150) #77

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+362 −152
Open

Add support for XML file upload pre-change (DCNE-150) #77

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
26b37aa
Add support for XML file upload pre-change
adealdag May 29, 2024
cf67a3b
Support using files with no extension for pre-change
adealdag Oct 17, 2024
c8d5904
Add lxml to requirements
adealdag Oct 21, 2024
1ea6164
Reduce scope of try-except block, and format with black
adealdag Oct 21, 2024
d0807ee
Add tests for invalid file and file with no ext
adealdag Oct 21, 2024
40dae7d
Add check for valid file extension with leading dot
adealdag Oct 27, 2024
9fff6c3
Add lxml to requirements.txt in root of project
adealdag Oct 29, 2024
c4b1f06
Fix sanity issues
adealdag Nov 11, 2024
8b4c94d
[ignore] black formatting
akinross Dec 16, 2024
9a7e03d
[ignore] split description in two lines to avoid sanity failures
akinross Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/httpapi/nd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ def send_file_request(self, method, path, file=None, data=None, remote_path=None

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run black -l 159 to format these changes.

# If file_ext is provided, replace the file extension (if present) or add it
if file_ext is not None:
if not file_ext.startswith(".") or file_ext not in set(mimetypes.types_map.keys()):
raise ValueError("Invalid file extension provided. Please provide a valid file extension, with leading dot")
akinross marked this conversation as resolved.
Show resolved Hide resolved
filename = os.path.splitext(os.path.basename(file))[0] + file_ext
else:
filename = os.path.basename(file)
Expand Down
Loading