Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables pure IPv6 configurations for nd_setup module on ND version 3.0.1 and later (DCNE-241) #108

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Dec 3, 2024

fixes #106

@gmicol gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Dec 3, 2024
@gmicol gmicol self-assigned this Dec 3, 2024
@akinross
Copy link
Collaborator

akinross commented Dec 3, 2024

black and sanity issues

…ions for nd_setup module on nd version 3.0.1 and later.
@gmicol gmicol force-pushed the nd_setup_ipv6_supported branch from 29f9c94 to cb1db84 Compare December 3, 2024 14:27
…rvice network for both IPv4 and IPv6 addresses.
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
@gmicol gmicol force-pushed the nd_setup_ipv6_supported branch from ab6e60d to 257882a Compare December 10, 2024 11:18
@gmicol gmicol requested a review from shrsr December 10, 2024 11:18
…tialization. Add conditions for Dual Stack configuration for version 3.0.1 or later.
@gmicol gmicol force-pushed the nd_setup_ipv6_supported branch from 257882a to 3fcbb58 Compare December 10, 2024 13:00
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
plugins/modules/nd_setup.py Outdated Show resolved Hide resolved
tests/integration/targets/nd_setup/tasks/main.yml Outdated Show resolved Hide resolved
@gmicol gmicol requested review from samiib and shrsr December 16, 2024 15:06
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit b2932d7 into CiscoDevNet:master Dec 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for IPv6-only ND Setup (DCNE-241)
5 participants