Add support for XML file upload pre-change (DCNE-150) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
samiib and
gmicol
anvitha-jain
approved these changes
May 31, 2024
lhercot
requested changes
Jun 13, 2024
samiib
changed the title
akinross
force-pushed
the
Fix-76-nd_pcv-fails-when-file-is-XML
branch
from
e8568bb to
26b37aa
Compare
|
Have modified the code according to prev conversation. Now the module is able to detect the type of file and deal with no extension or wrong extension files. |
akinross
requested review from
akinross,
lhercot,
shrsr,
anvitha-jain,
samiib and
gmicol
akinross
reviewed
Oct 23, 2024
| """This method handles file download and upload operations | ||
| :arg method (str): Method can be GET or POST | ||
| :arg path (str): Path should be the resource path | ||
| :arg file (str): The absolute file path of the target file | ||
| :arg file_ext (str): The file extension, with leading dot, to be used for the file. If file has already an extension, it will be replaced |
There was a problem hiding this comment.
should we add a check that the file extension leads with a dot? possibly error or inject when this is not done.
There was a problem hiding this comment.
Sounds good, added
akinross
requested changes
Oct 28, 2024
samiib
requested changes
Oct 28, 2024
samiib
requested changes
Oct 29, 2024
plugins/httpapi/nd.py
Outdated
| @@ -254,6 +255,14 @@ def send_file_request(self, method, path, file=None, data=None, remote_path=None | |||
| self.method = "GET" | |||
| if method is not None: | |||
| self.method = method | |||
|
|
|||
There was a problem hiding this comment.
Please run black -l 159 to format these changes.
plugins/modules/nd_pcv.py
Outdated
| try: | ||
| file_ext = ".json" | ||
| extract_data = ndi.load(open(file)) | ||
| except: |
There was a problem hiding this comment.
Suggested change
| except: | |
| except BaseException: |
I think this will also fix another sanity issue.
samiib
requested changes
Oct 29, 2024
samiib
requested changes
Dec 2, 2024
plugins/modules/nd_pcv.py
Outdated
| @@ -43,7 +43,7 @@ | |||
| aliases: [ site ] | |||
| file: | |||
| description: | |||
| - Optional parameter if creating new pre-change analysis from file. | |||
| - Optional parameter if creating new pre-change analysis from file. XML and JSON files are supported. If no file extension is provided, the file is assumed to be JSON. | |||
There was a problem hiding this comment.
Suggested change
| - Optional parameter if creating new pre-change analysis from file. XML and JSON files are supported. If no file extension is provided, the file is assumed to be JSON. | |
| - Optional parameter if creating new pre-change analysis from file. | |
| - XML and JSON files are supported. If no file extension is provided, the file is assumed to be JSON. |
To fix the long line sanity issue.
anvitha-jain
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #76