Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Added support for Ansible 2.18 and dropped support for 2.15 (DCNE-247) #707

Merged
merged 3 commits into from
Nov 20, 2024
Merged

[minor_change] Added support for Ansible 2.18 and dropped support for 2.15 (DCNE-247) #707

merged 3 commits into from
Nov 20, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Nov 19, 2024

Fixes #706

  • Updated supported Python version to 3.11
  • Fixed the additional sanity issues reported in Ansible Core 2.18
  • Fixed the seealso FQCN references

@samiib samiib self-assigned this Nov 19, 2024
@github-actions github-actions bot changed the title [minor_change] Added support for Ansible 2.18 and dropped support for 2.15 [minor_change] Added support for Ansible 2.18 and dropped support for 2.15 (DCNE-247) Nov 19, 2024
@samiib samiib marked this pull request as ready for review November 19, 2024 04:16
akinross
akinross requested changes Nov 19, 2024
View reviewed changes
plugins/modules/aci_interface_policy_hsrp.py Show resolved Hide resolved
.github/workflows/ansible-test.yml Show resolved Hide resolved
.github/workflows/ansible-test.yml Show resolved Hide resolved
plugins/modules/aci_cloud_subnet.py Show resolved Hide resolved
@samiib samiib requested a review from akinross November 19, 2024 08:58
akinross
akinross approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 7272ad6 into CiscoDevNet:master Nov 20, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees

@samiib samiib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seealso entries for modules/plugins without FQCNs, and some other sanity test failures (DCNE-247)
5 participants
@samiib @lhercot @shrsr @akinross @gmicol