[bug_fix]: Add subclass to aci_domain_to_vlan_pool to fix deletion of binding (DCNE-207)
#695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When state is absent, only the subclass for the domain should be deleted (infraRsVlanNs) not the whole domain config.
akinross
changed the title
aci_domain_to_vlan_pool to fix deletion of bindingaci_domain_to_vlan_pool to fix deletion of binding (DCNE-207)
akinross
requested changes
Oct 15, 2024
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
gmicol and
samiib
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
===========================================
- Coverage 94.65% 35.76% -58.90%
===========================================
Files 260 267 +7
Lines 12051 12205 +154
Branches 1826 1840 +14
===========================================
- Hits 11407 4365 -7042
- Misses 275 7840 +7565
+ Partials 369 0 -369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akinross
requested changes
Oct 16, 2024
Co-authored-by: Akini Ross <[email protected]>
|
Have updated the module with your proposal @akinross , thank you very much :) learning how these modules/filters work. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When state is absent, only the subclass for the domain should be deleted (infraRsVlanNs) not the whole domain config.