-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct vPC member side (DCNE-93) #663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9dc36a6
to
a55c799
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
===========================================
- Coverage 58.46% 35.75% -22.72%
===========================================
Files 269 266 -3
Lines 12352 12165 -187
Branches 1862 1837 -25
===========================================
- Hits 7222 4349 -2873
- Misses 5002 7816 +2814
+ Partials 128 0 -128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the bug.
Would it be okay to also update the tests for this module? It appears to be lacking some asserts that would have detected this issue if added.
@timcragg Hi Tim, just wondering if you are still working on this one or if you have had a chance to look at the PR review comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Minor bugfix - the l3extMember object uses side instead of name to build the DN, so the module should configure the side attribute instead of the name (I believe the name attribute is left as null if you build an l3extMember object through the APIC GUI).
Closes DCNE-93